tiflow
tiflow copied to clipboard
pingcap
gc(ticdc): add min service gc safe point metrics
What problem does this PR solve?
Issue Number: ref #10463
What is changed and how it works?
ticdc uses min service gc safe point to check whether data is GCed, this PR adds min service gc safe point metrics to ticdc dashboard, and with this metric, the user can easily understand why changefeed failed with ErrSnapshotLostByGC error
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.
Codecov Report
Merging #10553 (a806281) into master (b3d7106) will increase coverage by
0.3084%. Report is 12 commits behind head on master. The diff coverage is50.0000%.
Additional details and impacted files
| Components | Coverage Δ | |
|---|---|---|
| cdc | 62.4551% <50.0000%> (+0.5434%) |
:arrow_up: |
| dm | 51.2637% <ø> (+0.0383%) |
:arrow_up: |
| engine | 63.4218% <ø> (+0.0494%) |
:arrow_up: |
| Flag | Coverage Δ | |
|---|---|---|
| unit | 57.8620% <50.0000%> (+0.3084%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #10553 +/- ##
================================================
+ Coverage 57.5536% 57.8620% +0.3084%
================================================
Files 850 853 +3
Lines 126767 127403 +636
================================================
+ Hits 72959 73718 +759
+ Misses 48369 48229 -140
- Partials 5439 5456 +17
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: asddongmen, CharlesCheung96, flowbehappy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [CharlesCheung96,asddongmen]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
-
2024-01-26 09:55:17.555177734 +0000 UTC m=+1127359.119475438: :ballot_box_with_check: agreed by asddongmen. -
2024-02-05 03:10:43.813764224 +0000 UTC m=+153569.380534114: :ballot_box_with_check: agreed by CharlesCheung96.
