tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

consumer(ticdc): adjust kafka consumer update watermark logic

Open 3AceShowHand opened this issue 1 year ago • 15 comments

What problem does this PR solve?

Issue Number: close #10223

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

3AceShowHand avatar Jan 23 '24 03:01 3AceShowHand

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from 3aceshowhand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 23 '24 03:01 ti-chi-bot[bot]

/retest

3AceShowHand avatar Jan 23 '24 05:01 3AceShowHand

/retest

3AceShowHand avatar Jan 23 '24 07:01 3AceShowHand

/test all

purelind avatar Jan 23 '24 08:01 purelind

Codecov Report

Merging #10529 (115b694) into master (833943f) will increase coverage by 0.0280%. Report is 67 commits behind head on master. The diff coverage is 88.6597%.

Additional details and impacted files
Components Coverage Δ
cdc 62.0290% <88.6597%> (+0.0707%) :arrow_up:
dm 51.2197% <ø> (-0.0182%) :arrow_down:
engine 63.4025% <ø> (-0.0142%) :arrow_down:
Flag Coverage Δ
unit 57.6136% <88.6597%> (+0.0280%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10529        +/-   ##
================================================
+ Coverage   57.5856%   57.6136%   +0.0280%     
================================================
  Files           849        849                
  Lines        126707     126772        +65     
================================================
+ Hits          72965      73038        +73     
+ Misses        48279      48272         -7     
+ Partials       5463       5462         -1     

codecov[bot] avatar Jan 23 '24 09:01 codecov[bot]

/retest

3AceShowHand avatar Jan 24 '24 03:01 3AceShowHand

/test cdc-integration-kafka-test

3AceShowHand avatar Jan 25 '24 09:01 3AceShowHand

/test all

3AceShowHand avatar Jan 26 '24 03:01 3AceShowHand

/retest

3AceShowHand avatar Jan 26 '24 06:01 3AceShowHand

/test cdc-integration-kafka-test

3AceShowHand avatar Jan 26 '24 06:01 3AceShowHand

/test cdc-integration-storage-test

3AceShowHand avatar Jan 26 '24 09:01 3AceShowHand

/test cdc-integration-mysql-test

3AceShowHand avatar Jan 29 '24 05:01 3AceShowHand

/retest

3AceShowHand avatar Jan 29 '24 09:01 3AceShowHand

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Feb 04 '24 10:02 ti-chi-bot[bot]

@3AceShowHand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-kafka-test 115b694467e3554c8541957005b3120504a864fa link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Feb 26 '24 08:02 ti-chi-bot[bot]