tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

sink(ticdc): use pd clock in storage sink (#10351)

Open ti-chi-bot opened this issue 1 year ago • 22 comments

This is an automated cherry-pick of #10351

What problem does this PR solve?

Issue Number: close #10352, ref #10374

What is changed and how it works?

  • Use pdClock instead of local clock to generate date seperator.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`Fix the issue that date seperator generated by the storage sink may roll back in table scheduling scenarios`.

ti-chi-bot avatar Jan 22 '24 03:01 ti-chi-bot

/retest

CharlesCheung96 avatar Jan 24 '24 05:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 05:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 05:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 06:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 07:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 08:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 09:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 09:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 09:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 11:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 16:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 24 '24 17:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 25 '24 01:01 CharlesCheung96

/retest

asddongmen avatar Jan 25 '24 01:01 asddongmen

/retest

asddongmen avatar Jan 25 '24 02:01 asddongmen

/retest

asddongmen avatar Jan 25 '24 02:01 asddongmen

/retest

CharlesCheung96 avatar Jan 25 '24 05:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 25 '24 07:01 CharlesCheung96

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 25 '24 07:01 ti-chi-bot[bot]

/retest

CharlesCheung96 avatar Jan 25 '24 08:01 CharlesCheung96

/retest

CharlesCheung96 avatar Jan 25 '24 09:01 CharlesCheung96

/retest

CharlesCheung96 avatar Mar 28 '24 09:03 CharlesCheung96