tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

owner, metrics(ticdc): fix metrics (#10459)

Open ti-chi-bot opened this issue 1 year ago • 3 comments

This is an automated cherry-pick of #10459

What problem does this PR solve?

Issue Number: close #10449, close #10447, close #10438

What is changed and how it works?

  1. For #10449, always cleanup metrics whether the changefeed has been cleaned or not. image

  2. For #10447, use the type of ticdc_kvclient_pull_event_count to distinguish incresmental scan and real-time raft log. image

  3. For #10438, add changefeedStartTimeGauge metric, which record the changefeed create time and restart time. Note that changefeedStartTimeGauge records the physical time with millisecond precision. image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

ti-chi-bot avatar Jan 19 '24 08:01 ti-chi-bot

https://github.com/pingcap/tiflow/issues/10449 is batch cherry-pick in https://github.com/pingcap/tiflow/pull/10500. https://github.com/pingcap/tiflow/issues/10447 and https://github.com/pingcap/tiflow/issues/10438 do not need to cherry-pick to release-6.5.

CharlesCheung96 avatar Jan 23 '24 13:01 CharlesCheung96

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 31 '24 02:01 ti-chi-bot[bot]

/retest

kennytm avatar Mar 12 '24 13:03 kennytm