tiflow
tiflow copied to clipboard
cdc: revert something from PR 10139
What problem does this PR solve?
Issue Number: ref #10143
What is changed and how it works?
Revert something from PR #10139 . I guess it's introduced mistakely in branch manual merging.
Check List
Tests
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None
/retest
/retest
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: asddongmen, CharlesCheung96
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [CharlesCheung96,asddongmen]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
[LGTM Timeline notifier]
Timeline:
-
2023-12-19 07:29:50.619046373 +0000 UTC m=+946081.656273301
: :ballot_box_with_check: agreed by asddongmen. -
2023-12-21 09:09:08.45518634 +0000 UTC m=+1124839.492413268
: :ballot_box_with_check: agreed by CharlesCheung96.
/retest
/test all
Codecov Report
Merging #10318 (ec35122) into master (3e9c9de) will decrease coverage by
5.9148%
. Report is 337 commits behind head on master. The diff coverage is57.2286%
.
Additional details and impacted files
Components | Coverage Δ | |
---|---|---|
cdc | 61.8114% <57.2286%> (-1.5955%) |
:arrow_down: |
dm | 51.2214% <ø> (∅) |
|
engine | 63.3787% <ø> (∅) |
Flag | Coverage Δ | |
---|---|---|
unit | 57.4921% <57.2286%> (-5.9148%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #10318 +/- ##
================================================
- Coverage 63.4069% 57.4921% -5.9148%
================================================
Files 392 849 +457
Lines 51067 126099 +75032
================================================
+ Hits 32380 72497 +40117
- Misses 16385 48184 +31799
- Partials 2302 5418 +3116
/retest
/retest
/retest
/retest
/retest
/retest
/retest
/retest
/retest
@hicqu: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-dm-integration-test | ec351227584fa10975f966fee49628739d377fdc | link | true | /test dm-integration-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.