tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

(WIP)*(ticdc): remove cdc context

Open sdojjy opened this issue 6 months ago • 7 comments

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

sdojjy avatar Dec 11 '23 14:12 sdojjy

Please also change the package name from context to another more proper name.

asddongmen avatar Dec 14 '23 04:12 asddongmen

@sdojjy Please describe in the PR what problem you are trying to solve, and how do you solve it.

zhangjinpeng87 avatar Dec 18 '23 02:12 zhangjinpeng87

/retest-required

sdojjy avatar Dec 18 '23 06:12 sdojjy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 03 '24 07:04 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-04-03 07:07:51.95260432 +0000 UTC m=+427733.480144870: :ballot_box_with_check: agreed by 3AceShowHand.
  • 2024-04-03 07:11:08.248133067 +0000 UTC m=+427929.775673613: :ballot_box_with_check: agreed by asddongmen.

ti-chi-bot[bot] avatar Apr 03 '24 07:04 ti-chi-bot[bot]

Codecov Report

Merging #10279 (ef48a12) into master (c022fe0) will decrease coverage by 0.0032%. Report is 1 commits behind head on master. The diff coverage is 56.9230%.

Additional details and impacted files
Components Coverage Δ
cdc 61.6639% <56.9230%> (-0.0158%) :arrow_down:
dm 51.2677% <ø> (+0.0161%) :arrow_up:
engine 63.4161% <ø> (+0.0070%) :arrow_up:
Flag Coverage Δ
unit 57.3943% <56.9230%> (-0.0032%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10279        +/-   ##
================================================
- Coverage   57.3974%   57.3943%   -0.0032%     
================================================
  Files           850        849         -1     
  Lines        125070     124988        -82     
================================================
- Hits          71787      71736        -51     
+ Misses        47897      47861        -36     
- Partials       5386       5391         +5     

codecov[bot] avatar Apr 07 '24 09:04 codecov[bot]