tidb icon indicating copy to clipboard operation
tidb copied to clipboard

stats: set the default analyze column options to all

Open 0xPoe opened this issue 2 weeks ago • 6 comments

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/64992

Problem Summary:

What changed and how does it work?

Set the default analysis column options to all temporarily.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

0xPoe avatar Dec 11 '25 10:12 0xPoe

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 71.2752%. Comparing base (f51be60) to head (3fcd53f). :warning: Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64994        +/-   ##
================================================
+ Coverage   70.9069%   71.2752%   +0.3683%     
================================================
  Files          1888       1888                
  Lines        515663     515852       +189     
================================================
+ Hits         365641     367675      +2034     
+ Misses       125615     123855      -1760     
+ Partials      24407      24322        -85     
Flag Coverage Δ
integration 48.2915% <0.0000%> (+0.1429%) :arrow_up:
unit 66.0508% <100.0000%> (+0.4200%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 59.7087% <ø> (+0.2862%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 11 '25 11:12 codecov[bot]

/retest

0xPoe avatar Dec 11 '25 13:12 0xPoe

/retest

0xPoe avatar Dec 11 '25 15:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 07:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 07:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 07:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 10:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 10:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 10:12 0xPoe

Test locally for upgrade from v8.5.4:

  1. tiup playground v8.5.4 --tag predicate
  2. Check the vars:
select @@global.tidb_analyze_column_options;
+--------------------------------------+
| @@global.tidb_analyze_column_options |
+--------------------------------------+
| PREDICATE                            |
+--------------------------------------+
  1. Upgrade to the patch version: tiup playground v8.5.4 --db.binpath /Users/poe/code/tidb/bin/tidb-server --tag predicate
  2. check vars again:
select @@global.tidb_analyze_column_options;
+--------------------------------------+
| @@global.tidb_analyze_column_options |
+--------------------------------------+
| PREDICATE                            |
+--------------------------------------+

Test locally for new cluster:

  1. tiup playground v8.5.4 --db.binpath /Users/poe/code/tidb/bin/tidb-server
  2. Check vars:
select @@global.tidb_analyze_column_options;
+--------------------------------------+
| @@global.tidb_analyze_column_options |
+--------------------------------------+
| ALL                                  |
+--------------------------------------+

Test locally for upgrade from v8.2.0:

  1. tiup playground v8.2.0 --tag predicate-8.2.0
  2. Check vars:
TiDB [email protected]:(none)> select @@global.tidb_analyze_column_options;
(1193, "Unknown system variable 'tidb_analyze_column_options'")
  1. Upgrade to the patch version: tiup playground v8.2.0 --db.binpath /Users/poe/code/tidb/bin/tidb-server --tag predicate-8.2.0
  2. Check vars:
select @@global.tidb_analyze_column_options;
+--------------------------------------+
| @@global.tidb_analyze_column_options |
+--------------------------------------+
| ALL                                  |
+--------------------------------------+

0xPoe avatar Dec 12 '25 11:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 11:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 11:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 12:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 13:12 0xPoe

/retest

0xPoe avatar Dec 12 '25 14:12 0xPoe

/cc @terry1purcell @fixdb

0xPoe avatar Dec 12 '25 18:12 0xPoe

/test ?

purelind avatar Dec 12 '25 20:12 purelind

@purelind: The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-build-next-gen
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-integration-realcluster-test-next-gen
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-mysql-client-test-next-gen
/test pull-unit-test-ddlv1
/test pull-unit-test-next-gen
/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test-next-gen
/test pull-check-deps
/test pull-common-test
/test pull-e2e-test
/test pull-error-log-review
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test-next-gen
/test pull-integration-e2e-test-next-gen
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-mysql-test-next-gen
/test pull-sqllogic-test
/test pull-tiflash-integration-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_build_next_gen
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_integration_realcluster_test_next_gen
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test
pingcap/tidb/pull_mysql_client_test_next_gen
pingcap/tidb/pull_unit_test_next_gen
pull-check-deps
pull-error-log-review

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Dec 12 '25 20:12 ti-chi-bot[bot]

@purelind: The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 12 '25 20:12 tiprow[bot]

@ti-chi-bot[bot]: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

@purelind: The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-build-next-gen
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-integration-realcluster-test-next-gen
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-mysql-client-test-next-gen
/test pull-unit-test-ddlv1
/test pull-unit-test-next-gen
/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test-next-gen
/test pull-check-deps
/test pull-common-test
/test pull-e2e-test
/test pull-error-log-review
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test-next-gen
/test pull-integration-e2e-test-next-gen
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-mysql-test-next-gen
/test pull-sqllogic-test
/test pull-tiflash-integration-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_build_next_gen
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_integration_realcluster_test_next_gen
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test
pingcap/tidb/pull_mysql_client_test_next_gen
pingcap/tidb/pull_unit_test_next_gen
pull-check-deps
pull-error-log-review

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 12 '25 20:12 tiprow[bot]

/retest

purelind avatar Dec 12 '25 20:12 purelind

/retest

0xPoe avatar Dec 12 '25 21:12 0xPoe

[LGTM Timeline notifier]

Timeline:

  • 2025-12-12 11:24:56.56573121 +0000 UTC m=+1213041.379508781: :ballot_box_with_check: agreed by Leavrth.
  • 2025-12-12 22:06:47.814235419 +0000 UTC m=+1251552.628012991: :ballot_box_with_check: agreed by terry1purcell.

ti-chi-bot[bot] avatar Dec 12 '25 22:12 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, Leavrth, terry1purcell, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 12 '25 22:12 ti-chi-bot[bot]

/retest

fixdb avatar Dec 12 '25 22:12 fixdb

/retest

0xPoe avatar Dec 12 '25 23:12 0xPoe

In response to a cherrypick label: new pull request created to branch release-8.5: #65015. But this PR has conflicts, please resolve them!

ti-chi-bot avatar Dec 12 '25 23:12 ti-chi-bot