tidb icon indicating copy to clipboard operation
tidb copied to clipboard

ttl: fix the issue that the TTL execution summary for timeout job is empty (#61518)

Open ti-chi-bot opened this issue 2 weeks ago • 4 comments

This is an automated cherry-pick of #61518

What problem does this PR solve?

Issue Number: close #61509

Problem Summary:

What changed and how does it work?

  1. Create a new function summarizeTaskResultWithError to submit summary with error.
  2. Find all existing tasks and summary them when the ttl job timeout.

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that the summary for timeout TTL job is empty

ti-chi-bot avatar Dec 11 '25 02:12 ti-chi-bot

@YangKeao This PR has conflicts, I have hold it. Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

ti-chi-bot avatar Dec 11 '25 02:12 ti-chi-bot

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar Dec 11 '25 02:12 ti-chi-bot[bot]

/unhold

YangKeao avatar Dec 15 '25 06:12 YangKeao

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 15 '25 06:12 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-12-15 06:24:07.450712322 +0000 UTC m=+1454192.264489894: :ballot_box_with_check: agreed by YangKeao.
  • 2025-12-15 06:26:29.845486618 +0000 UTC m=+1454334.659264200: :ballot_box_with_check: agreed by lcwangchao.

ti-chi-bot[bot] avatar Dec 15 '25 06:12 ti-chi-bot[bot]

Codecov Report

:x: Patch coverage is 56.81818% with 19 lines in your changes missing coverage. Please review. :warning: Please upload report for BASE (release-8.5@7c29611). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #64967   +/-   ##
================================================
  Coverage               ?   58.5743%           
================================================
  Files                  ?       1816           
  Lines                  ?     653286           
  Branches               ?          0           
================================================
  Hits                   ?     382658           
  Misses                 ?     244469           
  Partials               ?      26159           
Flag Coverage Δ
integration 39.7456% <0.0000%> (?)
unit 72.3217% <56.8181%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 65.6444% <0.0000%> (?)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 15 '25 06:12 codecov[bot]

/retest

YangKeao avatar Dec 16 '25 02:12 YangKeao

/retest

YangKeao avatar Dec 16 '25 04:12 YangKeao

/retest

YangKeao avatar Dec 16 '25 07:12 YangKeao

/retest

hawkingrei avatar Dec 16 '25 11:12 hawkingrei

/test all

hawkingrei avatar Dec 16 '25 16:12 hawkingrei

/retest

hawkingrei avatar Dec 17 '25 01:12 hawkingrei

/retest

YangKeao avatar Dec 17 '25 05:12 YangKeao

/retest

EmmaDuDu avatar Dec 17 '25 07:12 EmmaDuDu

/retest

YangKeao avatar Dec 17 '25 09:12 YangKeao

/retest

YangKeao avatar Dec 17 '25 12:12 YangKeao

/retest

YangKeao avatar Dec 17 '25 13:12 YangKeao