tidb icon indicating copy to clipboard operation
tidb copied to clipboard

ddl: refine syntax details | tidb-test=feature/active-active tikv=feature/active-active

Open xhebox opened this issue 3 weeks ago • 9 comments

What problem does this PR solve?

Issue Number: ref #64281

Problem Summary: Refined syntax, more tests, hidden column, and new system variable tidb_translate_softdelete_sql

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

xhebox avatar Dec 10 '25 17:12 xhebox

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 10 '25 17:12 tiprow[bot]

Codecov Report

:x: Patch coverage is 77.73438% with 57 lines in your changes missing coverage. Please review. :warning: Please upload report for BASE (feature/active-active@b20f139). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             feature/active-active     #64962   +/-   ##
==========================================================
  Coverage                         ?   74.8312%           
==========================================================
  Files                            ?       1882           
  Lines                            ?     515862           
  Branches                         ?          0           
==========================================================
  Hits                             ?     386026           
  Misses                           ?     106112           
  Partials                         ?      23724           
Flag Coverage Δ
integration 48.3320% <77.9220%> (?)
unit 72.2449% <30.0781%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.2285% <0.0000%> (?)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 10 '25 17:12 codecov[bot]

/retest

xhebox avatar Dec 10 '25 18:12 xhebox

@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 10 '25 18:12 tiprow[bot]

/ok-to-test

xhebox avatar Dec 11 '25 02:12 xhebox

/retest

lcwangchao avatar Dec 11 '25 13:12 lcwangchao

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lcwangchao, tiancaiamao Once this PR has been reviewed and has the lgtm label, please assign ailinkid, benjamin2037, yudongusa for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 11 '25 15:12 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-12-11 06:15:40.940121671 +0000 UTC m=+1108085.753899244: :ballot_box_with_check: agreed by lcwangchao.
  • 2025-12-11 15:05:00.687016117 +0000 UTC m=+1139845.500793689: :ballot_box_with_check: agreed by tiancaiamao.

ti-chi-bot[bot] avatar Dec 11 '25 15:12 ti-chi-bot[bot]

/retest

xhebox avatar Dec 11 '25 16:12 xhebox