tidb icon indicating copy to clipboard operation
tidb copied to clipboard

executor: fix unexpected successful admin check in the table when no index record exists (#63871)

Open ti-chi-bot opened this issue 1 month ago • 4 comments

This is an automated cherry-pick of #63871

What problem does this PR solve?

Issue Number: close #63698

Problem Summary: meetError is not reset correctly.

What changed and how does it work?

Reset meetError before every check.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix unexpected successful admin check in the table when no index record exists

ti-chi-bot avatar Nov 28 '25 10:11 ti-chi-bot

@wjhuang2016 This PR has conflicts, I have hold it. Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

ti-chi-bot avatar Nov 28 '25 10:11 ti-chi-bot

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar Nov 28 '25 10:11 ti-chi-bot[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :warning: Please upload report for BASE (release-8.5@e4e814f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #64766   +/-   ##
================================================
  Coverage               ?   77.7520%           
================================================
  Files                  ?       1676           
  Lines                  ?     471427           
  Branches               ?          0           
================================================
  Hits                   ?     366544           
  Misses                 ?      83059           
  Partials               ?      21824           
Flag Coverage Δ
integration 51.7368% <100.0000%> (?)
unit 72.8554% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 67.5238% <0.0000%> (?)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 11 '25 02:12 codecov[bot]

@joechenrh: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Dec 12 '25 03:12 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, joechenrh, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 12 '25 03:12 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-12-12 03:19:10.771689422 +0000 UTC m=+1183895.585466984: :ballot_box_with_check: agreed by wjhuang2016.
  • 2025-12-12 03:32:27.946410392 +0000 UTC m=+1184692.760187984: :ballot_box_with_check: agreed by fzzf678.

ti-chi-bot[bot] avatar Dec 12 '25 03:12 ti-chi-bot[bot]

/retest

wjhuang2016 avatar Dec 12 '25 07:12 wjhuang2016

/test unit-test

EmmaDuDu avatar Dec 12 '25 13:12 EmmaDuDu

@EmmaDuDu: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 12 '25 13:12 tiprow[bot]

/retest

joechenrh avatar Dec 12 '25 14:12 joechenrh

/retest

joechenrh avatar Dec 12 '25 15:12 joechenrh

/retest

EmmaDuDu avatar Dec 13 '25 01:12 EmmaDuDu