planner: remove fullRange check from skyline pruning (#63828)
This is an automated cherry-pick of #63828
What problem does this PR solve?
Issue Number: ref #63235
Problem Summary:
What changed and how does it work?
FullRange check was found to be expensive in some scenarios. This PR restructures the skylinePruning logic to reduce reliance on this check. It uses other checks where possible, and also will only call this after other criteria has been validated.
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
@terry1purcell This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:warning: Please upload report for BASE (release-8.5@268e1df). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## release-8.5 #64447 +/- ##
================================================
Coverage ? 78.4353%
================================================
Files ? 1680
Lines ? 484799
Branches ? 0
================================================
Hits ? 380254
Misses ? 83327
Partials ? 21218
| Flag | Coverage Δ | |
|---|---|---|
| integration | 51.8001% <90.9090%> (?) |
|
| unit | 74.3756% <100.0000%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9278% <0.0000%> (?) |
|
| parser | ∅ <0.0000%> (?) |
|
| br | 61.5029% <0.0000%> (?) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
/unhold
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fixdb, terry1purcell
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/planner/OWNERS~~ [fixdb,terry1purcell]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
2025-11-13 18:59:01.829460035 +0000 UTC m=+987791.272489914: :ballot_box_with_check: agreed by fixdb.2025-11-13 21:17:10.230335797 +0000 UTC m=+996079.673365686: :ballot_box_with_check: agreed by terry1purcell.
/test mysql-test
@qw4990: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test mysql-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest