tidb icon indicating copy to clipboard operation
tidb copied to clipboard

importsdk: enhance import sdk

Open yitso opened this issue 2 months ago • 9 comments

What problem does this PR solve?

Issue Number: ref #61264

Problem Summary:

What changed and how does it work?

  1. add options to limit import sdk max scanned files
  2. add options to skip build table meta error to let sdk return the scanned valid table metas ranther than raise error
  3. add a new method let sdk create specific table

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

yitso avatar Oct 27 '25 14:10 yitso

Hi @yitso. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Oct 27 '25 14:10 ti-chi-bot[bot]

Welcome @yitso!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. :smiley:

ti-chi-bot[bot] avatar Oct 27 '25 14:10 ti-chi-bot[bot]

CLA assistant check
All committers have signed the CLA.

Hi @yitso. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Oct 27 '25 14:10 tiprow[bot]

/ok-to-test

joechenrh avatar Oct 28 '25 01:10 joechenrh

Codecov Report

:x: Patch coverage is 81.63265% with 9 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 73.5651%. Comparing base (6da2997) to head (4741774). :warning: Report is 32 commits behind head on master.

:warning: Current head 4741774 differs from pull request most recent head 0a7764d

Please upload reports for the commit 0a7764d to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64145        +/-   ##
================================================
+ Coverage   72.7343%   73.5651%   +0.8307%     
================================================
  Files          1856       1860         +4     
  Lines        501939     510625      +8686     
================================================
+ Hits         365082     375642     +10560     
+ Misses       114662     112756      -1906     
- Partials      22195      22227        +32     
Flag Coverage Δ
integration 41.8495% <ø> (?)
unit 72.6072% <81.6326%> (+0.3056%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (+0.1132%) :arrow_up:
parser ∅ <ø> (∅)
br 46.3497% <ø> (-0.0077%) :arrow_down:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 28 '25 04:10 codecov[bot]

/retest

yitso avatar Oct 31 '25 08:10 yitso

Codecov Report

:x: Patch coverage is 81.63265% with 9 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.8431%. Comparing base (8aefecd) to head (c8bd317).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64145        +/-   ##
================================================
- Coverage   70.9290%   68.8431%   -2.0859%     
================================================
  Files          1888       1867        -21     
  Lines        515954     524369      +8415     
================================================
- Hits         365961     360992      -4969     
- Misses       125582     140767     +15185     
+ Partials      24411      22610      -1801     
Flag Coverage Δ
integration 41.6624% <ø> (-6.4922%) :arrow_down:
unit 66.0290% <81.6326%> (+0.3649%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 39.1396% <ø> (-20.2853%) :arrow_down:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 04 '25 09:11 codecov[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign wshwsh12 for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 11 '25 13:12 ti-chi-bot[bot]