tidb
tidb copied to clipboard
executor: fix goroutine leak when exceed quota in hash agg (#58078)
This is an automated cherry-pick of #58078
What problem does this PR solve?
Issue Number: close #58004
Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
@xzhangxian1008 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.
/hold
/unhold
/retest
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
release-7.5@469af9d). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## release-7.5 #61805 +/- ##
================================================
Coverage ? 72.2593%
================================================
Files ? 1417
Lines ? 414543
Branches ? 0
================================================
Hits ? 299546
Misses ? 95002
Partials ? 19995
| Flag | Coverage Δ | |
|---|---|---|
| unit | 72.2593% <100.0000%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9400% <0.0000%> (?) |
|
| parser | ∅ <0.0000%> (?) |
|
| br | 53.5493% <0.0000%> (?) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@xzhangxian1008: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: windtalker, wshwsh12, xzhangxian1008
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [windtalker,wshwsh12]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
2025-06-26 02:24:35.365106943 +0000 UTC m=+929728.088285918: :ballot_box_with_check: agreed by windtalker.2025-06-27 01:59:42.013243039 +0000 UTC m=+1014634.736422039: :ballot_box_with_check: agreed by wshwsh12.