tidb icon indicating copy to clipboard operation
tidb copied to clipboard

executor: fix goroutine leak when exceed quota in hash agg (#58078)

Open ti-chi-bot opened this issue 5 months ago • 4 comments

This is an automated cherry-pick of #58078

What problem does this PR solve?

Issue Number: close #58004

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [x] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot avatar Jun 18 '25 08:06 ti-chi-bot

@xzhangxian1008 This PR has conflicts, I have hold it. Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

ti-chi-bot avatar Jun 18 '25 08:06 ti-chi-bot

/hold

xzhangxian1008 avatar Jun 20 '25 06:06 xzhangxian1008

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@796f6a0). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #61803   +/-   ##
================================================
  Coverage               ?   71.2230%           
================================================
  Files                  ?       1468           
  Lines                  ?     424211           
  Branches               ?          0           
================================================
  Hits                   ?     302136           
  Misses                 ?     101532           
  Partials               ?      20543           
Flag Coverage Δ
unit 71.2230% <80.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.4214% <0.0000%> (?)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 24 '25 09:06 codecov[bot]

/unhold

xzhangxian1008 avatar Jun 25 '25 01:06 xzhangxian1008

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 27 '25 01:06 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-06-25 02:41:13.131926411 +0000 UTC m=+844325.855105394: :ballot_box_with_check: agreed by windtalker.
  • 2025-06-27 01:17:17.583553405 +0000 UTC m=+1012090.306732386: :ballot_box_with_check: agreed by xzhangxian1008.

ti-chi-bot[bot] avatar Jun 27 '25 01:06 ti-chi-bot[bot]