tidb fix(runaway): resolve the dead chanel in UpdateNewAndDoneWatch

What problem does this PR solve?

Issue Number: close #61782.

Problem Summary:

Revert #52283 and implement a simpler method to prevent error logs.

What changed and how does it work?

Check List

Tests

[x] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Resolve the issue causing system table read/write operations related to runaways to hang after restarting TiDB instance.

Jun 18 '25 04:06 JmPotato

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.9152%. Comparing base (1040e03) to head (5e35a82). Report is 117 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #61795        +/-   ##
================================================
+ Coverage   73.0288%   76.9152%   +3.8863%     
================================================
  Files          1730       1795        +65     
  Lines        481656     517059     +35403     
================================================
+ Hits         351748     397697     +45949     
+ Misses       108355      96550     -11805     
- Partials      21553      22812      +1259

Flag	Coverage Δ
integration	`51.0951% <62.9629%> (?)`
unit	`74.1834% <100.0000%> (+1.9063%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7804% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`65.3041% <ø> (+18.7390%)`	:arrow_up:

:rocket: New features to boost your workflow:

:snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
:package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Jun 18 '25 05:06 codecov[bot]

Do we need to add some tests for this issue?

Jun 18 '25 08:06 okJiang

Do we need to add some tests for this issue?

I have added the manual test results in the PR description, please take a look.

Jun 19 '25 09:06 JmPotato

/retest

Jun 19 '25 11:06 xhebox

[LGTM Timeline notifier]

Timeline:

2025-06-18 07:49:04.56362981 +0000 UTC m=+257997.286808787: :ballot_box_with_check: agreed by okJiang.
2025-06-20 02:09:30.981114223 +0000 UTC m=+410423.704293207: :ballot_box_with_check: agreed by xhebox.

Jun 20 '25 02:06 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, tangenta, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [okJiang,tangenta,xhebox]
~~pkg/domain/OWNERS~~ [tangenta]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Jul 04 '25 08:07 ti-chi-bot[bot]

/test pull-br-integration-test

Jul 04 '25 08:07 JmPotato

@JmPotato: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Jul 04 '25 08:07 tiprow[bot]

/test unit-test

Jul 04 '25 12:07 JmPotato

@JmPotato: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Jul 04 '25 12:07 tiprow[bot]

/retest

Jul 05 '25 04:07 JmPotato

/test pull-lightning-integration-test

Jul 05 '25 05:07 JmPotato

@JmPotato: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Jul 05 '25 05:07 tiprow[bot]

/cherry-pick release-8.5

Jul 05 '25 07:07 JmPotato

@JmPotato: new pull request created to branch release-8.5: #62225.

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Jul 05 '25 07:07 ti-chi-bot

/cherry-pick release-8.1

Jul 09 '25 09:07 JmPotato

@JmPotato: new pull request created to branch release-8.1: #62322. But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Jul 09 '25 09:07 ti-chi-bot