domain: decouple info schema syncer
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
in nextgen, we need to access system tables of SYSTEM keyspace from user keyspace, and need to load its schema to make sure we can use correct row ID allocator when do insert. this PR is the first part to impl it. most part are moving and abstracting code, see comments for where logic are change
- move schema validator into a separate pkg
- decouple info schema syncer from domain, and split the info schema loader from syncer.
isin the code is the abbr forinfo schema
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [x] Manual test (add detailed scripts or steps below)
run with real-tikv, and upgrade from older version, both success
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @D3Hunter. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
Attention: Patch coverage is 84.63542% with 118 lines in your changes missing coverage. Please review.
Project coverage is 75.2905%. Comparing base (
6a12f31) to head (c8e7b75). Report is 17 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #61794 +/- ##
================================================
+ Coverage 73.0660% 75.2905% +2.2245%
================================================
Files 1730 1781 +51
Lines 481492 493403 +11911
================================================
+ Hits 351807 371486 +19679
+ Misses 108156 98923 -9233
- Partials 21529 22994 +1465
| Flag | Coverage Δ | |
|---|---|---|
| integration | 49.1916% <55.8593%> (?) |
|
| unit | 72.6353% <84.2242%> (+0.3346%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.7804% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 62.8979% <100.0000%> (+16.2107%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
[LGTM Timeline notifier]
Timeline:
2025-06-19 03:01:36.341146851 +0000 UTC m=+327149.064325828: :ballot_box_with_check: agreed by tangenta.2025-06-19 07:49:26.678058721 +0000 UTC m=+344419.401237699: :ballot_box_with_check: agreed by tiancaiamao.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Leavrth, tangenta, tiancaiamao
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Leavrth,tangenta,tiancaiamao]
- ~~br/OWNERS~~ [Leavrth]
- ~~pkg/ddl/OWNERS~~ [tangenta]
- ~~pkg/domain/OWNERS~~ [tangenta]
- ~~pkg/infoschema/OWNERS~~ [tangenta]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.