tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: optimize stats collection with buffer (WIP do not merge)

Open ichen032 opened this issue 6 months ago • 8 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ichen032 avatar Jun 17 '25 22:06 ichen032

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

:open_book: For more info, you can check the "Contribute Code" section in the development guide.

ti-chi-bot[bot] avatar Jun 17 '25 22:06 ti-chi-bot[bot]

Hi @ichen032. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Jun 17 '25 22:06 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign terry1purcell for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 17 '25 22:06 ti-chi-bot[bot]

Hi @ichen032. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 17 '25 22:06 tiprow[bot]

/ok-to-test

terry1purcell avatar Jun 17 '25 22:06 terry1purcell

@ichen032: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 91614b3d0a6b262f38c60945b4c5cc55cc16cd28 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tiprow[bot] avatar Jun 17 '25 22:06 tiprow[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.3350%. Comparing base (f46112d) to head (91614b3). Report is 13 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61789        +/-   ##
================================================
+ Coverage   73.1012%   73.3350%   +0.2337%     
================================================
  Files          1730       1760        +30     
  Lines        481253     489294      +8041     
================================================
+ Hits         351802     358824      +7022     
- Misses       107913     108211       +298     
- Partials      21538      22259       +721     
Flag Coverage Δ
integration 52.7534% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.9660% <ø> (ø)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 17 '25 22:06 codecov[bot]

@ichen032: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 91614b3d0a6b262f38c60945b4c5cc55cc16cd28 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev_2 91614b3d0a6b262f38c60945b4c5cc55cc16cd28 link true /test check-dev2
idc-jenkins-ci-tidb/unit-test 91614b3d0a6b262f38c60945b4c5cc55cc16cd28 link true /test unit-test
idc-jenkins-ci-tidb/check_dev 91614b3d0a6b262f38c60945b4c5cc55cc16cd28 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jun 17 '25 22:06 ti-chi-bot[bot]