tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: refactor order ratio code

Open terry1purcell opened this issue 6 months ago • 4 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

terry1purcell avatar Jun 17 '25 20:06 terry1purcell

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 17 '25 20:06 tiprow[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 73.2981%. Comparing base (c35d9ef) to head (227ae40). :warning: Report is 20 commits behind head on master.

:warning: Current head 227ae40 differs from pull request most recent head 2f1ec4d

Please upload reports for the commit 2f1ec4d to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61787        +/-   ##
================================================
+ Coverage   72.8847%   73.2981%   +0.4134%     
================================================
  Files          1771       1778         +7     
  Lines        486220     492752      +6532     
================================================
+ Hits         354380     361178      +6798     
+ Misses       110197     109673       -524     
- Partials      21643      21901       +258     
Flag Coverage Δ
integration 42.2664% <80.0000%> (?)
unit 72.1723% <100.0000%> (+0.0105%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 45.6185% <ø> (-0.7202%) :arrow_down:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 28 '25 04:06 codecov[bot]

/retest-required

terry1purcell avatar Jul 29 '25 03:07 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jul 29 '25 03:07 tiprow[bot]

/retest-required

terry1purcell avatar Aug 02 '25 19:08 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Aug 02 '25 19:08 tiprow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Aug 03 '25 19:08 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-08-01 06:50:10.050188769 +0000 UTC m=+246822.735458995: :ballot_box_with_check: agreed by qw4990.
  • 2025-08-03 19:22:03.196075979 +0000 UTC m=+209633.338837144: :ballot_box_with_check: agreed by time-and-fate.

ti-chi-bot[bot] avatar Aug 03 '25 19:08 ti-chi-bot[bot]

@terry1purcell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-unit-test-next-gen 2f1ec4d0a95ac55b88239cfccdbfe8709db6350b link false /test pull-unit-test-next-gen
non-block/pull-mysql-client-test-next-gen 2f1ec4d0a95ac55b88239cfccdbfe8709db6350b link false /test pull-mysql-client-test-next-gen
non-block/pull-integration-e2e-test-next-gen 2f1ec4d0a95ac55b88239cfccdbfe8709db6350b link false /test pull-integration-e2e-test-next-gen
non-block/pull-mysql-test-next-gen 2f1ec4d0a95ac55b88239cfccdbfe8709db6350b link false /test pull-mysql-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Aug 04 '25 05:08 ti-chi-bot[bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #62797. But this PR has conflicts, please resolve them!

ti-chi-bot avatar Aug 04 '25 05:08 ti-chi-bot