tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: adapt the normal plan build process to collect column-level visit info | tidb-test=pr/2532

Open CbcWestwolf opened this issue 6 months ago • 7 comments

What problem does this PR solve?

Issue Number: ref #61706

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

CbcWestwolf avatar Jun 15 '25 07:06 CbcWestwolf

Codecov Report

Attention: Patch coverage is 98.05195% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5-20250606-v8.5.2@e04e9dc). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-8.5-20250606-v8.5.2     #61741   +/-   ##
================================================================
  Coverage                               ?   57.0426%           
================================================================
  Files                                  ?       1770           
  Lines                                  ?     629391           
  Branches                               ?          0           
================================================================
  Hits                                   ?     359021           
  Misses                                 ?     246286           
  Partials                               ?      24084           
Flag Coverage Δ
integration 36.8971% <88.6363%> (?)
unit 72.7158% <96.7532%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.4164% <0.0000%> (?)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 15 '25 07:06 codecov[bot]

/retest

CbcWestwolf avatar Jun 16 '25 02:06 CbcWestwolf

/hold

CbcWestwolf avatar Jun 16 '25 09:06 CbcWestwolf

/retest

CbcWestwolf avatar Jun 18 '25 01:06 CbcWestwolf

/retest

CbcWestwolf avatar Jun 18 '25 02:06 CbcWestwolf

/retest

CbcWestwolf avatar Jun 20 '25 02:06 CbcWestwolf

/unhold

CbcWestwolf avatar Jun 20 '25 04:06 CbcWestwolf

/retest

CbcWestwolf avatar Jun 24 '25 08:06 CbcWestwolf

/test mysql-test

CbcWestwolf avatar Jun 24 '25 09:06 CbcWestwolf

@CbcWestwolf: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 24 '25 09:06 tiprow[bot]

/retest

CbcWestwolf avatar Jun 25 '25 07:06 CbcWestwolf

/retest

CbcWestwolf avatar Jun 25 '25 09:06 CbcWestwolf

/retest

CbcWestwolf avatar Jun 25 '25 11:06 CbcWestwolf

[LGTM Timeline notifier]

Timeline:

  • 2025-06-24 12:08:34.477429339 +0000 UTC m=+791967.200608321: :ballot_box_with_check: agreed by wjhuang2016.
  • 2025-06-25 13:59:45.341757221 +0000 UTC m=+885038.064936202: :ballot_box_with_check: agreed by tiancaiamao.

ti-chi-bot[bot] avatar Jun 25 '25 13:06 ti-chi-bot[bot]

@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Jun 26 '25 02:06 ti-chi-bot[bot]

@yudongusa: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Jun 26 '25 20:06 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, tiancaiamao, winoros, wjhuang2016, ystaticy, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 27 '25 01:06 ti-chi-bot[bot]