tidb icon indicating copy to clipboard operation
tidb copied to clipboard

ingest: retry failed regions when batch scatter regions

Open GMHDBJD opened this issue 6 months ago • 5 comments

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/60077

Problem Summary:

What changed and how does it work?

  • retry failed regions when batch scatter regions
  • cherrypick https://github.com/pingcap/tidb/pull/60839

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

GMHDBJD avatar Jun 13 '25 07:06 GMHDBJD

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 13 '25 07:06 tiprow[bot]

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.8085%. Comparing base (f770560) to head (0a83198). Report is 156 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61722        +/-   ##
================================================
+ Coverage   73.1149%   75.8085%   +2.6935%     
================================================
  Files          1730       1782        +52     
  Lines        481167     500011     +18844     
================================================
+ Hits         351805     379051     +27246     
+ Misses       107842      97946      -9896     
- Partials      21520      23014      +1494     
Flag Coverage Δ
integration 49.5291% <47.3684%> (?)
unit 73.1016% <84.6153%> (+0.7420%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 64.6215% <84.6153%> (+17.6387%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 13 '25 07:06 codecov[bot]

/retest

GMHDBJD avatar Jun 16 '25 09:06 GMHDBJD

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 16 '25 09:06 tiprow[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-06-19 09:52:59.332993437 +0000 UTC m=+351832.056172418: :ballot_box_with_check: agreed by Benjamin2037.
  • 2025-06-20 03:41:00.226545986 +0000 UTC m=+415912.949724992: :ballot_box_with_check: agreed by tangenta.

ti-chi-bot[bot] avatar Jun 20 '25 03:06 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, Benjamin2037, Leavrth, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Benjamin2037,Leavrth,bb7133,tangenta]
  • ~~br/OWNERS~~ [Leavrth]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 23 '25 02:06 ti-chi-bot[bot]

/retest

Benjamin2037 avatar Jun 23 '25 05:06 Benjamin2037

In response to a cherrypick label: new pull request created to branch release-8.1: #62287. But this PR has conflicts, please resolve them!

ti-chi-bot avatar Jul 08 '25 07:07 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.5: #62288. But this PR has conflicts, please resolve them!

ti-chi-bot avatar Jul 08 '25 07:07 ti-chi-bot