tidb icon indicating copy to clipboard operation
tidb copied to clipboard

executor: handle panic for fast admin check

Open joechenrh opened this issue 5 months ago • 6 comments

What problem does this PR solve?

Issue Number: ref #61612

Problem Summary:

What changed and how does it work?

This is a manual cherry-pick for https://github.com/pingcap/tidb/pull/55537, which add panic handle logic for WorkerPool.

This PR only pick codes related to fast admin check back to release7.5, i.e. handle panic for checkIndexTask, to avoid check pass when underlying SQLs meet panic.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

joechenrh avatar Jun 13 '25 03:06 joechenrh

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 13 '25 03:06 tiprow[bot]

/retest

joechenrh avatar Jun 13 '25 05:06 joechenrh

@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 13 '25 05:06 tiprow[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-06-13 05:29:58.510978443 +0000 UTC m=+592176.739293706: :ballot_box_with_check: agreed by Benjamin2037.
  • 2025-06-16 05:45:48.294676569 +0000 UTC m=+77801.017855550: :ballot_box_with_check: agreed by lance6716.

ti-chi-bot[bot] avatar Jun 16 '25 05:06 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Benjamin2037,lance6716,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 18 '25 09:06 ti-chi-bot[bot]

/retest

joechenrh avatar Jun 19 '25 01:06 joechenrh

@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 19 '25 01:06 tiprow[bot]

Codecov Report

:x: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review. :warning: Please upload report for BASE (release-7.5@15a52d8). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #61718   +/-   ##
================================================
  Coverage               ?   72.1728%           
================================================
  Files                  ?       1417           
  Lines                  ?     414178           
  Branches               ?          0           
================================================
  Hits                   ?     298924           
  Misses                 ?      95237           
  Partials               ?      20017           
Flag Coverage Δ
unit 72.1728% <87.5000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5384% <0.0000%> (?)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 19 '25 02:06 codecov[bot]