tidb
tidb copied to clipboard
pingcap
planner: fix index merge skyline pruning may be prior to choose distinct partial index rather than the low count one. (#61372)
This is an automated cherry-pick of #61372
What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tidb/issues/61093 Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [x] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
@AilinKid This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.
Codecov Report
Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
Please upload report for BASE (
release-8.5@f43a133). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## release-8.5 #61562 +/- ##
================================================
Coverage ? 57.0404%
================================================
Files ? 1771
Lines ? 628959
Branches ? 0
================================================
Hits ? 358761
Misses ? 246084
Partials ? 24114
| Flag | Coverage Δ | |
|---|---|---|
| integration | 36.9146% <94.4444%> (?) |
|
| unit | 72.6927% <88.8888%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9278% <0.0000%> (?) |
|
| parser | ∅ <0.0000%> (?) |
|
| br | 52.4356% <0.0000%> (?) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@AilinKid: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test check-dev2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![tiprow[bot] avatar](https://avatars.githubusercontent.com/in/18927?v=4 "Published by a pub.dev verified publisher"){kind=small}
[LGTM Timeline notifier]
Timeline:
2025-06-18 07:47:46.431180857 +0000 UTC m=+257919.154359838: :ballot_box_with_check: agreed by hawkingrei.2025-06-20 06:08:36.007065468 +0000 UTC m=+424768.730244449: :ballot_box_with_check: agreed by AilinKid.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
@AilinKid: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test check-dev2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@AilinKid: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test check-dev2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@AilinKid: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test check-dev2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@AilinKid: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test check-dev2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@AilinKid: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test check-dev2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@AilinKid: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test check-dev2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-integration-tidb-tools-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/release-8.5/pull_build
pingcap/tidb/release-8.5/pull_check
pingcap/tidb/release-8.5/pull_check2
pingcap/tidb/release-8.5/pull_mysql_test
pingcap/tidb/release-8.5/pull_unit_test
In response to this:
/test unit-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@AilinKid: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test unit-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ti-chi-bot[bot]: No presubmit jobs available for pingcap/[email protected]
In response to this:
@AilinKid: The specified target(s) for
/testwere not found. The following commands are available to trigger required jobs:/test build/test check-dev/test check-dev2/test mysql-test/test pull-br-integration-test/test pull-unit-test-ddlv1/test unit-testThe following commands are available to trigger optional jobs:
/test pull-common-test/test pull-e2e-test/test pull-integration-common-test/test pull-integration-copr-test/test pull-integration-ddl-test/test pull-integration-e2e-test/test pull-integration-jdbc-test/test pull-integration-mysql-test/test pull-integration-nodejs-test/test pull-integration-python-orm-test/test pull-integration-tidb-tools-test/test pull-lightning-integration-test/test pull-mysql-client-test/test pull-sqllogic-test/test pull-tiflash-testUse
/test allto run the following jobs that were automatically triggered:pingcap/tidb/release-8.5/pull_buildpingcap/tidb/release-8.5/pull_checkpingcap/tidb/release-8.5/pull_check2pingcap/tidb/release-8.5/pull_mysql_testpingcap/tidb/release-8.5/pull_unit_testIn response to this:
/test unit-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AilinKid, hawkingrei, wjhuang2016
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [AilinKid,hawkingrei,wjhuang2016]
- ~~pkg/disttask/OWNERS~~ [wjhuang2016]
- ~~pkg/planner/OWNERS~~ [AilinKid,hawkingrei]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment