tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: predicate simplification when to push down predicate with LogicalSelection | tidb-test=pr/2523

Open hawkingrei opened this issue 6 months ago • 10 comments

What problem does this PR solve?

Issue Number: close #61489

Problem Summary:

What changed and how does it work?

  1. predicate simplification when to push down the predicate with LogicalSelection
  2. Improve the plan cache check in the predicate simplification. Now, predicate simplification can make use of the plan cache.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: predicate simplification when to push down predicate with LogicalSelection

在对 LogicalSelection 进行谓语下堆时,进行简化

hawkingrei avatar Jun 04 '25 09:06 hawkingrei

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.0330%. Comparing base (02c4202) to head (dc6d3a8). Report is 59 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61495        +/-   ##
================================================
+ Coverage   73.0192%   73.0330%   +0.0137%     
================================================
  Files          1735       1735                
  Lines        481429     481471        +42     
================================================
+ Hits         351536     351633        +97     
+ Misses       108351     108272        -79     
- Partials      21542      21566        +24     
Flag Coverage Δ
unit 72.2740% <100.0000%> (+0.0159%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5728% <ø> (+0.0129%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 04 '25 11:06 codecov[bot]

/retest

hawkingrei avatar Jun 04 '25 12:06 hawkingrei

CLA assistant check
All committers have signed the CLA.

/retest

hawkingrei avatar Jun 04 '25 16:06 hawkingrei

/retest

hawkingrei avatar Jun 04 '25 16:06 hawkingrei

/retest

hawkingrei avatar Jun 06 '25 07:06 hawkingrei

/retest

hawkingrei avatar Jun 18 '25 01:06 hawkingrei

/retest

hawkingrei avatar Jun 18 '25 01:06 hawkingrei

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign windtalker, winoros for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 20 '25 16:06 ti-chi-bot[bot]

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-e2e-test-next-gen 7146d01eefd033beba3f0fb8c1f910a792259362 link false /test pull-integration-e2e-test-next-gen
idc-jenkins-ci-tidb/mysql-test dc6d3a8bd55990f8f27edd1985928b0f84680b53 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev dc6d3a8bd55990f8f27edd1985928b0f84680b53 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jun 20 '25 16:06 ti-chi-bot[bot]