tidb
tidb copied to clipboard
[DNM]statistic: only debug for skipping insert stats_meta after table creation
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @Leavrth. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.5313%. Comparing base (fcf376c) to head (f8309d8).
:warning: Report is 833 commits behind head on master.
:warning: Current head f8309d8 differs from pull request most recent head ced6d35
Please upload reports for the commit ced6d35 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #61120 +/- ##
================================================
+ Coverage 72.9360% 74.5313% +1.5952%
================================================
Files 1736 1778 +42
Lines 482461 509465 +27004
================================================
+ Hits 351888 379711 +27823
+ Misses 109001 106879 -2122
- Partials 21572 22875 +1303
| Flag | Coverage Δ | |
|---|---|---|
| integration | 46.1573% <100.0000%> (?) |
|
| unit | 72.1455% <0.0000%> (-0.0378%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.7804% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 61.8632% <100.0000%> (+15.2817%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
[FORMAT CHECKER NOTIFICATION]
Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.
For example:
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bb7133, benjamin2037, yujuncen for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Leavrth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| non-block-pull-unit-test-ddlv1-next-gen | 98a651d453743394675c3aceec1acb8f8b1a7648 | link | false | /test pull-unit-test-ddlv1-next-gen |
| non-block-pull-check-next-gen | 98a651d453743394675c3aceec1acb8f8b1a7648 | link | false | /test pull-check-next-gen |
| non-block-pull-unit-test-next-gen | 98a651d453743394675c3aceec1acb8f8b1a7648 | link | false | /test pull-unit-test-next-gen |
| non-block-pull-build-next-gen | 98a651d453743394675c3aceec1acb8f8b1a7648 | link | false | /test pull-build-next-gen |
| non-block/pull-unit-test-next-gen | 4db476fc9b7914abe8c96fb768f9b62c32f4652f | link | false | /test pull-unit-test-next-gen |
| pull-br-integration-test | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-br-integration-test |
| pull-build-next-gen | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-build-next-gen |
| pull-integration-e2e-test | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-integration-e2e-test |
| pull-mysql-client-test | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-mysql-client-test |
| idc-jenkins-ci-tidb/check_dev | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test check-dev |
| pull-integration-realcluster-test-next-gen | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-integration-realcluster-test-next-gen |
| idc-jenkins-ci-tidb/check_dev_2 | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test check-dev2 |
| pull-unit-test-ddlv1 | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-unit-test-ddlv1 |
| idc-jenkins-ci-tidb/mysql-test | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test mysql-test |
| pull-unit-test-next-gen | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-unit-test-next-gen |
| idc-jenkins-ci-tidb/build | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test build |
| pull-lightning-integration-test | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-lightning-integration-test |
| pull-mysql-client-test-next-gen | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-mysql-client-test-next-gen |
| pull-integration-ddl-test | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test pull-integration-ddl-test |
| idc-jenkins-ci-tidb/unit-test | ced6d35a3e5cee8228c591ea9f0a70ce75d1fb16 | link | true | /test unit-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.