tidb icon indicating copy to clipboard operation
tidb copied to clipboard

ddl: remove unnecessary `PrefixNext()` during `iterateSnapshotKeys()`

Open tangenta opened this issue 7 months ago • 6 comments

What problem does this PR solve?

Issue Number: close #61026

Problem Summary:

See #61026

What changed and how does it work?

Remove unnecessary PrefixNext() during iterateSnapshotKeys().

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [x] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tangenta avatar May 08 '25 09:05 tangenta

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar May 08 '25 09:05 tiprow[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 78.3220%. Comparing base (c157641) to head (1d0878c). :warning: Report is 862 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61027        +/-   ##
================================================
+ Coverage   73.1297%   78.3220%   +5.1922%     
================================================
  Files          1723       1897       +174     
  Lines        476955     576248     +99293     
================================================
+ Hits         348796     451329    +102533     
+ Misses       106742     101422      -5320     
- Partials      21417      23497      +2080     
Flag Coverage Δ
integration 48.8316% <100.0000%> (?)
unit 76.9527% <100.0000%> (+4.6057%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9532% <ø> (+0.1728%) :arrow_up:
parser ∅ <ø> (∅)
br 61.9001% <ø> (+14.4009%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 08 '25 09:05 codecov[bot]

/retest

tangenta avatar May 08 '25 09:05 tangenta

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar May 08 '25 09:05 tiprow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 18 '25 12:06 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-06-18 12:05:59.150435366 +0000 UTC m=+273411.873614343: :ballot_box_with_check: agreed by wjhuang2016.

ti-chi-bot[bot] avatar Jun 18 '25 12:06 ti-chi-bot[bot]