tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: fix a PromQL syntax error (#60705)

Open ti-chi-bot opened this issue 8 months ago • 18 comments

This is an automated cherry-pick of #60705

What problem does this PR solve?

Issue Number: close #60212

Problem Summary:

fix a promql syntax issue in backup&restore panel. As a workaround, please goto tikv panel to check br related metrics.

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [X] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot avatar Apr 22 '25 11:04 ti-chi-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lysu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 22 '25 11:04 ti-chi-bot[bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Apr 22 '25 11:04 ti-chi-bot[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :warning: Please upload report for BASE (release-7.1@7e3ec4e). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #60713   +/-   ##
================================================
  Coverage               ?   73.4596%           
================================================
  Files                  ?       1213           
  Lines                  ?     382162           
  Branches               ?          0           
================================================
  Hits                   ?     280735           
  Misses                 ?      83486           
  Partials               ?      17941           
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 22 '25 11:04 codecov[bot]

/test pull-e2e-test

lybcodes avatar Dec 11 '25 02:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 11 '25 02:12 tiprow[bot]

/test pull-integration-common-test

lybcodes avatar Dec 11 '25 02:12 lybcodes

/test pull-integration-ddl-test

lybcodes avatar Dec 11 '25 02:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-common-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 11 '25 02:12 tiprow[bot]

/test pull-integration-binlog-test

lybcodes avatar Dec 11 '25 02:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-ddl-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 11 '25 02:12 tiprow[bot]

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-binlog-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 11 '25 02:12 tiprow[bot]

/test pull-integration-jdbc-test

lybcodes avatar Dec 11 '25 02:12 lybcodes

/test pull-integration-copr-test

lybcodes avatar Dec 11 '25 02:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-jdbc-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 11 '25 02:12 tiprow[bot]

/test pull-integration-mysql-test

lybcodes avatar Dec 11 '25 02:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-copr-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 11 '25 02:12 tiprow[bot]

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 11 '25 02:12 tiprow[bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-test 356bc8fd666511434b22596a814f4e8d2b8fdf37 link false /test pull-e2e-test
pull-integration-common-test 356bc8fd666511434b22596a814f4e8d2b8fdf37 link false /test pull-integration-common-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Dec 11 '25 02:12 ti-chi-bot[bot]