tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: Add redact for storage credential infos (#60086)

Open ti-chi-bot opened this issue 9 months ago • 18 comments

This is an automated cherry-pick of #60086

What problem does this PR solve?

Issue Number: close #60209

Problem Summary: We need to redact credential info in log

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot avatar Mar 25 '25 08:03 ti-chi-bot

@RidRisR This PR has conflicts, I have hold it. Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

ti-chi-bot avatar Mar 25 '25 08:03 ti-chi-bot

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Mar 25 '25 08:03 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign morgo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 25 '25 08:03 ti-chi-bot[bot]

/test pull-e2e-test

lybcodes avatar Dec 10 '25 16:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 10 '25 16:12 tiprow[bot]

/test pull-integration-binlog-test

lybcodes avatar Dec 10 '25 16:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-binlog-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 10 '25 16:12 tiprow[bot]

/test pull-integration-common-test

lybcodes avatar Dec 10 '25 16:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-common-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 10 '25 16:12 tiprow[bot]

/test pull-integration-copr-test

lybcodes avatar Dec 10 '25 16:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-copr-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 10 '25 16:12 tiprow[bot]

/test pull-integration-ddl-test

lybcodes avatar Dec 10 '25 16:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-ddl-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 10 '25 16:12 tiprow[bot]

/test pull-integration-jdbc-test

lybcodes avatar Dec 10 '25 16:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-jdbc-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 10 '25 16:12 tiprow[bot]

/test pull-integration-mysql-test

lybcodes avatar Dec 10 '25 16:12 lybcodes

@lybcodes: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-integration-mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 10 '25 16:12 tiprow[bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev c13e24c7a8053cf12260ba8bcaf9339fc5f0ea7b link true /test check-dev
idc-jenkins-ci-tidb/unit-test c13e24c7a8053cf12260ba8bcaf9339fc5f0ea7b link true /test unit-test
idc-jenkins-ci-tidb/build c13e24c7a8053cf12260ba8bcaf9339fc5f0ea7b link true /test build
idc-jenkins-ci-tidb/check_dev_2 c13e24c7a8053cf12260ba8bcaf9339fc5f0ea7b link true /test check-dev2
pull-integration-copr-test c13e24c7a8053cf12260ba8bcaf9339fc5f0ea7b link false /test pull-integration-copr-test
pull-integration-common-test c13e24c7a8053cf12260ba8bcaf9339fc5f0ea7b link false /test pull-integration-common-test
pull-integration-jdbc-test c13e24c7a8053cf12260ba8bcaf9339fc5f0ea7b link false /test pull-integration-jdbc-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Dec 10 '25 16:12 ti-chi-bot[bot]