pingcap
stmt: clean `rowContainer` if the execution paniced (#59985)
This is an automated cherry-pick of #59985
What problem does this PR solve?
Issue Number: close #59963, close #59976
Problem Summary:
- The row container will not be closed if the exclusion panic.
- The results and cursor will not be reset if there is an error in
cc.flush.
What changed and how does it work?
- Set the row container of stmt right after creating it. Therefore, it can be closed after closing the connection.
Check List
Tests
- [ ] Unit test
- [x] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.
To merge this cherry pick:
- It must be approved by the approvers firstly.
- AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tiancaiamao for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@lybcodes: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test pull-e2e-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![tiprow[bot] avatar](https://avatars.githubusercontent.com/in/18927?v=4 "Published by a pub.dev verified publisher"){kind=small}
@lybcodes: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test pull-integration-binlog-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@lybcodes: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test pull-integration-common-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@lybcodes: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test pull-integration-copr-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@lybcodes: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test pull-integration-ddl-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@lybcodes: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test pull-integration-jdbc-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@lybcodes: No presubmit jobs available for pingcap/[email protected]
In response to this:
/test pull-integration-mysql-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| idc-jenkins-ci-tidb/check_dev_2 | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | true | /test check-dev2 |
| idc-jenkins-ci-tidb/build | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | true | /test build |
| idc-jenkins-ci-tidb/unit-test | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | true | /test unit-test |
| idc-jenkins-ci-tidb/check_dev | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | true | /test check-dev |
| idc-jenkins-ci-tidb/mysql-test | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | true | /test mysql-test |
| pull-e2e-test | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | false | /test pull-e2e-test |
| pull-integration-common-test | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | false | /test pull-integration-common-test |
| pull-integration-ddl-test | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | false | /test pull-integration-ddl-test |
| pull-integration-binlog-test | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | false | /test pull-integration-binlog-test |
| pull-integration-jdbc-test | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | false | /test pull-integration-jdbc-test |
| pull-integration-copr-test | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | false | /test pull-integration-copr-test |
| pull-integration-mysql-test | ec2bb7e058088e771076b1edb9c23bf39ac20f81 | link | false | /test pull-integration-mysql-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.