tidb icon indicating copy to clipboard operation
tidb copied to clipboard

statistics: rename queue files for consistency

Open 0xPoe opened this issue 1 year ago • 3 comments

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/55906

Problem Summary:

What changed and how does it work?

  1. Renamed queue_v2_xxx.go to queue_xxx.go. Because we only have one version now.
  2. Refactored FetchAllTablesAndBuildAnalysisJobs as a method of the priority queue.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

0xPoe avatar Oct 20 '24 13:10 0xPoe

Codecov Report

Attention: Patch coverage is 71.26866% with 154 lines in your changes missing coverage. Please review.

Project coverage is 56.9039%. Comparing base (e13bfeb) to head (a0c96f0). Report is 29 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56732         +/-   ##
=================================================
- Coverage   73.3262%   56.9039%   -16.4224%     
=================================================
  Files          1630       1786        +156     
  Lines        450312     646607     +196295     
=================================================
+ Hits         330197     367945      +37748     
- Misses        99833     253880     +154047     
- Partials      20282      24782       +4500     
Flag Coverage Δ
integration 38.6749% <4.2910%> (?)
unit 72.8942% <71.2686%> (+0.4341%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5250% <ø> (+6.9362%) :arrow_up:

codecov[bot] avatar Oct 20 '24 13:10 codecov[bot]

/retest

0xPoe avatar Oct 21 '24 01:10 0xPoe

/retest

0xPoe avatar Oct 21 '24 04:10 0xPoe

/retest

0xPoe avatar Oct 21 '24 05:10 0xPoe

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 08:46:03.570435736 +0000 UTC m=+340764.267226339: :ballot_box_with_check: agreed by lance6716.
  • 2024-10-23 06:16:39.465255017 +0000 UTC m=+418200.162045622: :ballot_box_with_check: agreed by elsa0520.

ti-chi-bot[bot] avatar Oct 23 '24 06:10 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Oct 23 '24 06:10 ti-chi-bot[bot]