tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: inject table metas as kv instead of DDL for testkit boostrap

Open lcwangchao opened this issue 1 year ago • 6 comments

What problem does this PR solve?

Issue Number: close #56727

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

lcwangchao avatar Oct 18 '24 11:10 lcwangchao

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Oct 18 '24 11:10 tiprow[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 56.9360%. Comparing base (4275195) to head (975a263). :warning: Report is 2212 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56728         +/-   ##
=================================================
- Coverage   73.3497%   56.9360%   -16.4138%     
=================================================
  Files          1634       1784        +150     
  Lines        452548     639395     +186847     
=================================================
+ Hits         331943     364046      +32103     
- Misses       100247     250288     +150041     
- Partials      20358      25061       +4703     
Flag Coverage Δ
integration 51.2859% <92.3076%> (?)
unit 72.5949% <100.0000%> (-0.0614%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 64.2140% <ø> (∅)
parser ∅ <ø> (∅)
br 62.5054% <ø> (+15.9167%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 18 '24 11:10 codecov[bot]

/retest

lcwangchao avatar Oct 18 '24 13:10 lcwangchao

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Oct 18 '24 13:10 tiprow[bot]

/retest

lcwangchao avatar Oct 21 '24 02:10 lcwangchao

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Oct 21 '24 02:10 tiprow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign benmeadowcroft, d3hunter, windtalker for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Oct 21 '24 06:10 ti-chi-bot[bot]

/hold

lcwangchao avatar Oct 25 '24 08:10 lcwangchao

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Nov 08 '24 08:11 ti-chi-bot[bot]

@lcwangchao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lightning-integration-test 975a2633ecbf8d697a899c26c408b3382410c6c2 link true /test pull-lightning-integration-test
pull-br-integration-test 975a2633ecbf8d697a899c26c408b3382410c6c2 link true /test pull-br-integration-test
pull-integration-e2e-test 975a2633ecbf8d697a899c26c408b3382410c6c2 link true /test pull-integration-e2e-test
pull-integration-realcluster-test-next-gen 975a2633ecbf8d697a899c26c408b3382410c6c2 link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen 975a2633ecbf8d697a899c26c408b3382410c6c2 link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Sep 26 '25 14:09 ti-chi-bot[bot]