tidb icon indicating copy to clipboard operation
tidb copied to clipboard

bootstrap: create the ddl notifier table

Open 0xPoe opened this issue 1 year ago • 11 comments

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/55722

Problem Summary:

What changed and how does it work?

  1. Created the ddl notifier table.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

0xPoe avatar Oct 18 '24 06:10 0xPoe

Codecov Report

Attention: Patch coverage is 51.16279% with 21 lines in your changes missing coverage. Please review.

Project coverage is 55.0199%. Comparing base (e13bfeb) to head (3521564). Report is 3 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56723         +/-   ##
=================================================
- Coverage   73.3262%   55.0199%   -18.3064%     
=================================================
  Files          1630       1779        +149     
  Lines        450312     636973     +186661     
=================================================
+ Hits         330197     350462      +20265     
- Misses        99833     263407     +163574     
- Partials      20282      23104       +2822     
Flag Coverage Δ
integration 34.7649% <51.1627%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 46.0067% <ø> (+0.4179%) :arrow_up:

codecov[bot] avatar Oct 18 '24 07:10 codecov[bot]

/retest

0xPoe avatar Oct 19 '24 12:10 0xPoe

/retest

0xPoe avatar Oct 20 '24 08:10 0xPoe

/retest

0xPoe avatar Oct 20 '24 09:10 0xPoe

/retest

0xPoe avatar Oct 20 '24 10:10 0xPoe

/retest

0xPoe avatar Oct 20 '24 12:10 0xPoe

/retest

0xPoe avatar Oct 20 '24 13:10 0xPoe

/retest

0xPoe avatar Oct 20 '24 13:10 0xPoe

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from rustin170506 and additionally assign wjhuang2016 for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Oct 20 '24 14:10 ti-chi-bot[bot]

@Rustin170506: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 352156487d032e77ab6fe500841d59c977de089c link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tiprow[bot] avatar Oct 20 '24 14:10 tiprow[bot]

@Rustin170506: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 352156487d032e77ab6fe500841d59c977de089c link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/unit-test 352156487d032e77ab6fe500841d59c977de089c link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 352156487d032e77ab6fe500841d59c977de089c link true /test check-dev2
pull-lightning-integration-test 352156487d032e77ab6fe500841d59c977de089c link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Oct 20 '24 15:10 ti-chi-bot[bot]