tidb
tidb copied to clipboard
br: improve summary and progress visualization of br
What problem does this PR solve?
Issue Number: close #56493
Problem Summary: See the issue.
What changed and how does it work?
add more details in the summary. And split the progress of snapshot restore
Detail BR log in /tmp/br.log.2024-10-12T15.39.51+0800
Split&Scatter Region <----------------------------------------------------------------------------------------------------> 100.00%
Download&Ingest SST <-----------------------------------------------------------------------------------------------------> 100.00%
Restore Pipeline <--------------------------------------------------------------------------------------------------------> 100.00%
[2024/10/12 15:47:55.497 +08:00] [INFO] [collector.go:77] ["Full Restore success summary"] [total-ranges=863] [ranges-succeed=863] [ranges-failed=0] [merge-ranges=7.546971ms] [split-region=343.594072ms] [restore-files=5m3.576621503s] [default-CF-files=278] [write-CF-files=558] [split-keys=386] [total-take=6m35.304887635s] [total-kv=871760372] [total-kv-size=143.8GB] [average-speed=363.8MB/s] [restore-data-size(after-compressed)=62.07GB] [Size=62072785167] [BackupTS=452625823236882437] [RestoreTS=453237563041775617]
merge-ranges: the time consumption of ranges merge.
split-region: the time consumption of regions split&scatter.
restore-files: the time consumption of SST files download&ingest.
default-CF-files: the number of default CF files.
write-CF-files: the number of write CF files.
split-keys: the number of keys to split regions.
Detail BR log in /tmp/br.log.2024-10-17T10.25.13+0800
Full Backup <------------------------------------------------------------------------------------------------------------------------------> 100.00%
Checksum <---------------------------------------------------------------------------------------------------------------------------------> 100.00%
[2024/10/17 10:31:38.602 +08:00] [INFO] [collector.go:77] ["Full Backup success summary"] [total-ranges=1813] [ranges-succeed=1813] [ranges-failed=0] [backup-fast-checksum=17.400535ms] [backup-checksum=1m26.440733343s] [backup-total-ranges=157] [backup-total-regions=510] [write-CF-files=1188] [default-CF-files=625] [total-take=6m25.007059103s] [total-kv=871788040] [total-kv-size=143.8GB] [average-speed=373.5MB/s] [backup-data-size(after-compressed)=62.07GB] [Size=62073954324] [BackupTS=453281586797346817]
backup-total-regions: the approximate number of regions backed up.
default-CF-files: the number of default CF files.
write-CF-files: the number of write CF files.
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @Leavrth. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
Attention: Patch coverage is 84.14634% with 26 lines in your changes missing coverage. Please review.
Project coverage is 74.9134%. Comparing base (
36e8e34) to head (2191949). Report is 254 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #56612 +/- ##
================================================
+ Coverage 73.0285% 74.9134% +1.8849%
================================================
Files 1684 1702 +18
Lines 465663 471739 +6076
================================================
+ Hits 340067 353396 +13329
+ Misses 104691 96664 -8027
- Partials 20905 21679 +774
| Flag | Coverage Δ | |
|---|---|---|
| integration | 46.5120% <84.1463%> (?) |
|
| unit | 72.6679% <15.8536%> (+0.4561%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.6910% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 61.3691% <84.1463%> (+16.1371%) |
:arrow_up: |
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
/retest
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: BornChanger, YuJuncen
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~br/OWNERS~~ [BornChanger,YuJuncen]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
2025-01-17 06:21:13.376593028 +0000 UTC m=+272344.831639172: :ballot_box_with_check: agreed by BornChanger.2025-01-22 04:43:53.549623502 +0000 UTC m=+242360.880542906: :ballot_box_with_check: agreed by YuJuncen.