tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: enable fix control for enforced | tidb-test=pr/2404

Open terry1purcell opened this issue 1 year ago • 4 comments

What problem does this PR solve?

Issue Number: close #46177

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

terry1purcell avatar Sep 29 '24 10:09 terry1purcell

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 29 '24 10:09 tiprow[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.2987%. Comparing base (255ea42) to head (4bae7a9). Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56414         +/-   ##
=================================================
- Coverage   73.3472%   56.2987%   -17.0486%     
=================================================
  Files          1635       1760        +125     
  Lines        452734     631632     +178898     
=================================================
+ Hits         332068     355601      +23533     
- Misses       100306     251996     +151690     
- Partials      20360      24035       +3675     
Flag Coverage Δ
integration 36.7264% <100.0000%> (?)
unit 72.4845% <100.0000%> (+0.0103%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6981% <ø> (+6.6655%) :arrow_up:

codecov[bot] avatar Sep 29 '24 10:09 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Oct 22 '24 13:10 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 06:33:21.867751937 +0000 UTC m=+941357.287964944: :ballot_box_with_check: agreed by qw4990.
  • 2024-10-22 13:10:29.712269557 +0000 UTC m=+356630.409060182: :ballot_box_with_check: agreed by winoros.

ti-chi-bot[bot] avatar Oct 22 '24 13:10 ti-chi-bot[bot]