tidb icon indicating copy to clipboard operation
tidb copied to clipboard

[WIP] *: Move updateRawArgs into `Job` and `SubJob`

Open joechenrh opened this issue 1 year ago • 5 comments

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/54436

Problem Summary:

What changed and how does it work?

Move updateRawArgs into Job and SubJob as a non-persistent field.

It's set to true each time FillArgs or FillFinishedArgs are called and set to false when Encode is called.

This shall be merged after all arguments are refactored.

Check List

Tests

  • [X] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

joechenrh avatar Sep 27 '24 01:09 joechenrh

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign 3pointer, wjhuang2016 for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 27 '24 01:09 ti-chi-bot[bot]

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 27 '24 01:09 tiprow[bot]

Codecov Report

Attention: Patch coverage is 85.58559% with 16 lines in your changes missing coverage. Please review.

Project coverage is 57.0052%. Comparing base (025c2a3) to head (b404db4). Report is 1367 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56351         +/-   ##
=================================================
- Coverage   73.3320%   57.0052%   -16.3269%     
=================================================
  Files          1629       1777        +148     
  Lines        449708     636440     +186732     
=================================================
+ Hits         329780     362804      +33024     
- Misses        99711     248584     +148873     
- Partials      20217      25052       +4835     
Flag Coverage Δ
integration 52.0363% <85.5855%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <ø> (∅)
parser ∅ <ø> (∅)
br 62.9497% <ø> (+16.6776%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 27 '24 01:09 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Oct 18 '24 10:10 ti-chi-bot[bot]

@joechenrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 b404db4b29e3a3c152494ec6ddf1b0124c37502f link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/unit-test b404db4b29e3a3c152494ec6ddf1b0124c37502f link true /test unit-test
pull-integration-e2e-test b404db4b29e3a3c152494ec6ddf1b0124c37502f link true /test pull-integration-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Nov 18 '24 04:11 ti-chi-bot[bot]