tidb icon indicating copy to clipboard operation
tidb copied to clipboard

[WIP] *: Move updateRawArgs into `Job` and `SubJob`

Open joechenrh opened this issue 5 months ago • 5 comments

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/54436

Problem Summary:

What changed and how does it work?

Move updateRawArgs into Job and SubJob as a non-persistent field.

It's set to true each time FillArgs or FillFinishedArgs are called and set to false when Encode is called.

This shall be merged after all arguments are refactored.

Check List

Tests

  • [X] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

joechenrh avatar Sep 27 '24 01:09 joechenrh