*: set default shard_row_id_bits and pre_split_regions for all tables
What problem does this PR solve?
Issue Number: close #55716
Problem Summary:
What changed and how does it work?
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Introduced variables `tidb_shard_row_id_bits` and `tidb_pre_split_regions`, to change the default values of `shard_row_id_bits` and `pre_split_regions`, avoiding setting them individually for each table.
Codecov Report
Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.
Project coverage is 58.3319%. Comparing base (
499e45f) to head (04127e4). Report is 52 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #55717 +/- ##
=================================================
- Coverage 72.8489% 58.3319% -14.5171%
=================================================
Files 1604 1756 +152
Lines 445733 643839 +198106
=================================================
+ Hits 324712 375564 +50852
- Misses 101000 243773 +142773
- Partials 20021 24502 +4481
| Flag | Coverage Δ | |
|---|---|---|
| integration | 41.3738% <53.1250%> (?) |
|
| unit | 73.6243% <93.7500%> (+1.6630%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9567% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 64.3915% <ø> (+18.6506%) |
:arrow_up: |
/test check-dev
@jackysp: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test fast_test_tiprow/test tidb_parser_test
Use /test all to run all jobs.
In response to this:
/test check-dev
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
/hold
new feature need confirm from PM
The default values are the same as in prior versions, and it supports setting the values at the session level. LGTM.
[LGTM Timeline notifier]
Timeline:
2024-09-04 03:22:47.210870662 +0000 UTC m=+414691.728923572: :ballot_box_with_check: agreed by tangenta.2024-09-05 01:14:33.066485455 +0000 UTC m=+493397.584538380: :ballot_box_with_check: agreed by Benjamin2037.
/hold
@jackysp I just hold this pr and let PM Frank help open an FD for this issue,sync with you!
@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@yudongusa PTAL, thanks!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Benjamin2037, Frank945946, tangenta, yudongusa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Benjamin2037,tangenta]
- ~~pkg/ddl/OWNERS~~ [Benjamin2037,tangenta]
- ~~pkg/sessionctx/variable/OWNERS~~ [yudongusa]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/unhold