tidb icon indicating copy to clipboard operation
tidb copied to clipboard

statistics: fix the error that init stats might got failure when decoding column bucket

Open winoros opened this issue 1 year ago • 7 comments

What problem does this PR solve?

Issue Number: close #55684

Problem Summary:

What changed and how does it work?

The old init stats doesn't handle the collation string.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

winoros avatar Aug 27 '24 08:08 winoros

Codecov Report

Attention: Patch coverage is 18.75000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 59.4504%. Comparing base (290dc46) to head (c12dcd4). Report is 115 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55685         +/-   ##
=================================================
- Coverage   72.9295%   59.4504%   -13.4792%     
=================================================
  Files          1581       1761        +180     
  Lines        442365     662905     +220540     
=================================================
+ Hits         322615     394100      +71485     
- Misses        99938     244752     +144814     
- Partials      19812      24053       +4241     
Flag Coverage Δ
integration 41.8544% <0.0000%> (?)
unit 75.0657% <18.7500%> (+3.0656%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.5253% <ø> (+1.5686%) :arrow_up:
parser ∅ <ø> (∅)
br 54.1246% <ø> (+8.6697%) :arrow_up:

codecov[bot] avatar Aug 27 '24 08:08 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Aug 27 '24 11:08 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-08-27 08:06:16.969055407 +0000 UTC m=+857572.103505528: :ballot_box_with_check: agreed by hawkingrei.
  • 2024-08-27 11:21:13.683312832 +0000 UTC m=+869268.817762950: :ballot_box_with_check: agreed by time-and-fate.

ti-chi-bot[bot] avatar Aug 27 '24 11:08 ti-chi-bot[bot]

/retest

winoros avatar Aug 27 '24 12:08 winoros

/retest

winoros avatar Aug 28 '24 09:08 winoros

/check-issue-triage-complete

hawkingrei avatar Aug 28 '24 09:08 hawkingrei

/retest

winoros avatar Sep 10 '24 16:09 winoros

/retest

winoros avatar Sep 11 '24 14:09 winoros

In response to a cherrypick label: new pull request created to branch release-6.5: #56024.

ti-chi-bot avatar Sep 11 '24 15:09 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.1: #56025.

ti-chi-bot avatar Sep 11 '24 15:09 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.5: #56026.

ti-chi-bot avatar Sep 11 '24 15:09 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.1: #56027.

ti-chi-bot avatar Sep 11 '24 15:09 ti-chi-bot