tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: restore merge split ranges with small data

Open Leavrth opened this issue 1 year ago • 5 comments

What problem does this PR solve?

Issue Number: close #53532

Problem Summary: br restore splits too many regions if there are too many small tables whose data size is less than region size.

What changed and how does it work?

ignore some keys to split less regions Due to https://github.com/tikv/tikv/issues/17278, BR needs merge the generated SSTMeta at the same region into one Ingest request.

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [x] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Leavrth avatar Aug 26 '24 09:08 Leavrth

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Aug 26 '24 09:08 tiprow[bot]

Codecov Report

Attention: Patch coverage is 83.84401% with 58 lines in your changes missing coverage. Please review.

Project coverage is 57.3650%. Comparing base (eb19c10) to head (a0803fd). Report is 159 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55662         +/-   ##
=================================================
- Coverage   72.8613%   57.3650%   -15.4964%     
=================================================
  Files          1595       1732        +137     
  Lines        449065     631859     +182794     
=================================================
+ Hits         327195     362466      +35271     
- Misses       101574     245051     +143477     
- Partials      20296      24342       +4046     
Flag Coverage Δ
integration 38.7040% <75.7660%> (?)
unit 72.1102% <61.5598%> (+0.1726%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (+0.0266%) :arrow_up:
parser ∅ <ø> (∅)
br 62.5596% <83.8440%> (+17.1840%) :arrow_up:

codecov[bot] avatar Aug 26 '24 09:08 codecov[bot]

/retest

Leavrth avatar Aug 28 '24 07:08 Leavrth

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Aug 28 '24 07:08 tiprow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 04 '24 08:09 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-09-03 05:39:49.912402368 +0000 UTC m=+336514.430455288: :ballot_box_with_check: agreed by YuJuncen.
  • 2024-09-04 08:29:56.364410535 +0000 UTC m=+433120.882463459: :ballot_box_with_check: agreed by 3pointer.

ti-chi-bot[bot] avatar Sep 04 '24 08:09 ti-chi-bot[bot]

/ok-to-test

Leavrth avatar Sep 04 '24 08:09 Leavrth

/retest

Leavrth avatar Sep 04 '24 09:09 Leavrth

/retest

Leavrth avatar Sep 04 '24 10:09 Leavrth

In response to a cherrypick label: new pull request created to branch release-7.5: #56279.

ti-chi-bot avatar Sep 25 '24 03:09 ti-chi-bot