tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: preference range scan for pseudo | tidb-test=pr/2382

Open terry1purcell opened this issue 1 year ago • 10 comments

What problem does this PR solve?

Issue Number: close #55632

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

terry1purcell avatar Aug 23 '24 23:08 terry1purcell

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Aug 23 '24 23:08 tiprow[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.2658%. Comparing base (dd18083) to head (bfeacd7). Report is 30 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55633         +/-   ##
=================================================
- Coverage   72.9114%   58.2658%   -14.6456%     
=================================================
  Files          1604       1760        +156     
  Lines        445657     649763     +204106     
=================================================
+ Hits         324935     378590      +53655     
- Misses       100688     246280     +145592     
- Partials      20034      24893       +4859     
Flag Coverage Δ
integration 41.0707% <100.0000%> (?)
unit 73.5063% <100.0000%> (+1.4817%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 62.8902% <ø> (+17.1169%) :arrow_up:

codecov[bot] avatar Aug 23 '24 23:08 codecov[bot]

/retest

terry1purcell avatar Aug 26 '24 00:08 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Aug 26 '24 00:08 tiprow[bot]

/retest

terry1purcell avatar Aug 27 '24 00:08 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Aug 27 '24 00:08 tiprow[bot]

/retest

terry1purcell avatar Aug 28 '24 23:08 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Aug 28 '24 23:08 tiprow[bot]

/retest

terry1purcell avatar Sep 03 '24 21:09 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 03 '24 21:09 tiprow[bot]

/retest

terry1purcell avatar Sep 05 '24 20:09 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 05 '24 20:09 tiprow[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-09-05 06:23:21.692939459 +0000 UTC m=+511926.210992384: :ballot_box_with_check: agreed by qw4990.
  • 2024-09-06 11:53:54.817695277 +0000 UTC m=+11704.558119213: :ballot_box_with_check: agreed by time-and-fate.

ti-chi-bot[bot] avatar Sep 06 '24 11:09 ti-chi-bot[bot]

/retest

terry1purcell avatar Sep 06 '24 23:09 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 06 '24 23:09 tiprow[bot]

/retest

terry1purcell avatar Sep 07 '24 14:09 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 07 '24 14:09 tiprow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, tangenta, time-and-fate, winoros, wjhuang2016, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 10 '24 04:09 ti-chi-bot[bot]

/retest

terry1purcell avatar Sep 10 '24 15:09 terry1purcell

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 10 '24 15:09 tiprow[bot]

/ok-to-test

hawkingrei avatar Sep 10 '24 16:09 hawkingrei