pingcap
Planner: Single col out of range use original type
What problem does this PR solve?
Issue Number: close #55199
Problem Summary:
What changed and how does it work?
Index histograms are stored as type string to support the potential for multiple columns with different types to have their histograms combined into a consistent type. This conversion to string can result in a loss of precision when comparing out of range estimation. This fix will use the original column histogram data for out of range estimation.
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @terry1purcell. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![tiprow[bot] avatar](https://avatars.githubusercontent.com/in/18927?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.7240%. Comparing base (
42edc22) to head (29cc812). Report is 97 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #55600 +/- ##
================================================
+ Coverage 73.0924% 73.7240% +0.6316%
================================================
Files 1715 1724 +9
Lines 475074 492489 +17415
================================================
+ Hits 347243 363083 +15840
- Misses 106476 107979 +1503
- Partials 21355 21427 +72
| Flag | Coverage Δ | |
|---|---|---|
| integration | 42.9791% <100.0000%> (?) |
|
| unit | 72.7932% <100.0000%> (+0.4853%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.7118% <ø> (+0.0564%) |
:arrow_up: |
| parser | ∅ <ø> (∅) |
|
| br | 45.6949% <ø> (-1.5905%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Rustin170506, winoros
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Rustin170506,winoros]
- ~~pkg/planner/OWNERS~~ [Rustin170506,winoros]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
[LGTM Timeline notifier]
Timeline:
2025-04-27 07:32:12.450329013 +0000 UTC m=+772876.262119393: :ballot_box_with_check: agreed by Rustin170506.2025-04-29 15:36:10.874815092 +0000 UTC m=+974714.686605473: :ballot_box_with_check: agreed by winoros.
@terry1purcell: new pull request created to branch release-6.5: #61364.
But this PR has conflicts, please resolve them!
In response to this:
/cherry-pick release-6.5
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@terry1purcell: new pull request created to branch release-7.1: #61365.
But this PR has conflicts, please resolve them!
In response to this:
/cherry-pick release-7.1
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@terry1purcell: new pull request created to branch release-8.5: #62156.
But this PR has conflicts, please resolve them!
In response to this:
/cherry-pick release-8.5
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@terry1purcell: new pull request created to branch release-7.5: #62259.
But this PR has conflicts, please resolve them!
In response to this:
/cherry-pick release-7.5
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@terry1purcell: new pull request created to branch release-8.1: #62260.
But this PR has conflicts, please resolve them!
In response to this:
/cherry-pick release-8.1
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.