pingcap
lightning: support prepared statement and client stmt cache in logical import mode
What problem does this PR solve?
Issue Number: close #54850
Problem Summary:
What changed and how does it work?
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
add doc for logical-import-prep-stmt
Test logical import on a table with 1200 columns
Baseline
With this PR
Hi @dbsid. Thanks for your PR.
I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @dbsid. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![tiprow[bot] avatar](https://avatars.githubusercontent.com/in/18927?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Attention: Patch coverage is 82.41758% with 16 lines in your changes missing coverage. Please review.
Project coverage is 73.6674%. Comparing base (
2651b77) to head (8869768). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #55482 +/- ##
================================================
+ Coverage 73.4071% 73.6674% +0.2603%
================================================
Files 1600 1631 +31
Lines 443627 447086 +3459
================================================
+ Hits 325654 329357 +3703
+ Misses 98033 97618 -415
- Partials 19940 20111 +171
| Flag | Coverage Δ | |
|---|---|---|
| integration | 43.9952% <0.0000%> (?) |
|
| unit | 72.4941% <82.4175%> (+0.0239%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9567% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 45.7885% <ø> (-0.0910%) |
:arrow_down: |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
please prepare a doc pr to this feature
https://github.com/pingcap/docs/pull/18902 https://github.com/pingcap/docs-cn/pull/18627
[LGTM Timeline notifier]
Timeline:
2024-09-09 09:10:55.080272051 +0000 UTC m=+261124.820695992: :ballot_box_with_check: agreed by lance6716.2024-09-18 07:00:07.956322065 +0000 UTC m=+1030877.696746004: :ballot_box_with_check: agreed by D3Hunter.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: D3Hunter, lance6716, qw4990, yudongusa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~lightning/OWNERS~~ [D3Hunter,lance6716,yudongusa]
- ~~pkg/lightning/OWNERS~~ [D3Hunter,lance6716]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@dbsid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test fast_test_tiprow/test tidb_parser_test
Use /test all to run all jobs.
In response to this:
/test pull-integration-ddl-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@dbsid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test fast_test_tiprow/test tidb_parser_test
Use /test all to run all jobs.
In response to this:
/test unit-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@dbsid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| fast_test_tiprow | 88697688b414b1d61c1291735316168f2a2797bb | link | true | /test fast_test_tiprow |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
