tidb
tidb copied to clipboard
*: Refactor runaway related code
What problem does this PR solve?
Refactor runaway related code
- Take the concept of the syncer out of the domain and put it into the manager, the domain only interacts with the manager.
- Refine runaway code in domain/runaway, e.g. put loops in manager instead of domain
- Moved runaway code to pkg/resourcegroup (can move the ResourceGroup-related code later).
- table operations of runaway have been put together with the record, and are called by manager/checker/syncer.
Issue Number: Ref #54434
Problem Summary:
What changed and how does it work?
Check List
Tests
- [x] Unit test
- [x] Integration test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Hi @HuSharp. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test all
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test all
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test all
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test all
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test all
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test all
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test all
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
Attention: Patch coverage is 79.54286% with 179 lines in your changes missing coverage. Please review.
Project coverage is 58.2631%. Comparing base (
c74a233) to head (dbe7d12). Report is 106 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #55202 +/- ##
=================================================
- Coverage 74.9176% 58.2631% -16.6545%
=================================================
Files 1576 1743 +167
Lines 365707 646216 +280509
=================================================
+ Hits 273979 376506 +102527
- Misses 71965 244954 +172989
- Partials 19763 24756 +4993
| Flag | Coverage Δ | |
|---|---|---|
| integration | 40.4574% <21.9428%> (?) |
|
| unit | 73.0834% <79.5428%> (-0.8247%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9567% <ø> (-2.2327%) |
:arrow_down: |
| parser | ∅ <ø> (∅) |
|
| br | 60.1983% <ø> (+12.3799%) |
:arrow_up: |
/test all
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@glorv @JmPotato @tangenta PTAL, thx~
[LGTM Timeline notifier]
Timeline:
@XuHuaiyu PTAL, thx~
/retest-required
/retest-required
/retest-required
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest-required
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test fast_test_tiprow
@HuSharp: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build/test check-dev/test check-dev2/test mysql-test/test pull-br-integration-test/test pull-integration-ddl-test/test pull-lightning-integration-test/test pull-mysql-client-test/test unit-test
The following commands are available to trigger optional jobs:
/test canary-notify-when-compatibility-sections-changed/test pingcap/tidb/canary_ghpr_unit_test/test pull-common-test/test pull-e2e-test/test pull-integration-common-test/test pull-integration-copr-test/test pull-integration-jdbc-test/test pull-integration-mysql-test/test pull-integration-nodejs-test/test pull-sqllogic-test/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_buildpingcap/tidb/ghpr_checkpingcap/tidb/ghpr_check2pingcap/tidb/ghpr_mysql_testpingcap/tidb/ghpr_unit_testpingcap/tidb/pull_br_integration_testpingcap/tidb/pull_integration_ddl_testpingcap/tidb/pull_mysql_client_test
In response to this:
/test fast_test_tiprow
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test fast_test_tiprow
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test