tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: classify logical max one row into a separate file for later pkg move

Open AilinKid opened this issue 1 year ago • 4 comments

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/51664, ref https://github.com/pingcap/tidb/issues/52714

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [x] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

AilinKid avatar Jul 01 '24 06:07 AilinKid

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jul 01 '24 06:07 tiprow[bot]

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.1432%. Comparing base (e985478) to head (f70a6c3).

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54356         +/-   ##
=================================================
- Coverage   72.8279%   56.1432%   -16.6847%     
=================================================
  Files          1531       1647        +116     
  Lines        435995     603068     +167073     
=================================================
+ Hits         317526     338582      +21056     
- Misses        98827     241254     +142427     
- Partials      19642      23232       +3590     
Flag Coverage Δ
integration 36.5973% <85.0000%> (?)
unit 71.8239% <85.0000%> (+0.0001%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.7176% <ø> (+6.5811%) :arrow_up:

codecov[bot] avatar Jul 01 '24 07:07 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 01 '24 08:07 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-07-01 08:07:00.997652551 +0000 UTC m=+1225347.483141382: :ballot_box_with_check: agreed by hawkingrei.
  • 2024-07-01 08:09:31.987783569 +0000 UTC m=+1225498.473272400: :ballot_box_with_check: agreed by qw4990.

ti-chi-bot[bot] avatar Jul 01 '24 08:07 ti-chi-bot[bot]

/retest

hawkingrei avatar Jul 01 '24 08:07 hawkingrei

/test check-dev2

AilinKid avatar Jul 02 '24 06:07 AilinKid

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jul 02 '24 06:07 tiprow[bot]

/ok-to-test

AilinKid avatar Jul 02 '24 06:07 AilinKid