tidb
tidb copied to clipboard
planner: classify logical window into a separate file for later pkg move.
What problem does this PR solve?
Issue Number: ref https://github.com/pingcap/tidb/issues/51664, ref https://github.com/pingcap/tidb/issues/52714
Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @AilinKid. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
Attention: Patch coverage is 54.92958% with 96 lines in your changes missing coverage. Please review.
Project coverage is 55.7634%. Comparing base (
91bf332) to head (9626964). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #54338 +/- ##
=================================================
- Coverage 72.8263% 55.7634% -17.0629%
=================================================
Files 1530 1651 +121
Lines 435981 607563 +171582
=================================================
+ Hits 317509 338798 +21289
- Misses 98827 245609 +146782
- Partials 19645 23156 +3511
| Flag | Coverage Δ | |
|---|---|---|
| integration | 36.4587% <54.9295%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9656% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 52.3469% <ø> (+6.2052%) |
:arrow_up: |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hawkingrei, qw4990
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/planner/OWNERS~~ [hawkingrei,qw4990]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
2024-07-01 08:06:47.541874954 +0000 UTC m=+1225334.027363783: :ballot_box_with_check: agreed by hawkingrei.2024-07-01 08:09:26.940725472 +0000 UTC m=+1225493.426214323: :ballot_box_with_check: agreed by qw4990.
/retest-required
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest-required
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest-required
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test unit-test
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test unit-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.