tidb icon indicating copy to clipboard operation
tidb copied to clipboard

tools/ut.go: add concurrent when listing pkgs

Open HuSharp opened this issue 1 year ago • 4 comments

What problem does this PR solve?

Issue Number: Ref #30822

Problem Summary:

What changed and how does it work?

We can list pkg concurrently to accelerate build

check result

go clean -testcache
make gotest_in_verify_ci

before

building task finish, parallelism=144, count=5297, takes=2m5.029385545s

after

building task finish, parallelism=144, count=5297, takes=1m16.911219387s

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [x] Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

HuSharp avatar Jun 28 '24 07:06 HuSharp

cc @tiancaiamao @bb7133

HuSharp avatar Jun 28 '24 07:06 HuSharp

Hi @HuSharp. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 28 '24 07:06 tiprow[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.6628%. Comparing base (00eafc0) to head (9432360). Report is 141 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54306         +/-   ##
=================================================
- Coverage   74.8294%   56.6628%   -18.1667%     
=================================================
  Files          1516       1644        +128     
  Lines        360862     622740     +261878     
=================================================
+ Hits         270031     352862      +82831     
- Misses        71259     246487     +175228     
- Partials      19572      23391       +3819     
Flag Coverage Δ
integration 37.0683% <ø> (?)
unit 71.8094% <ø> (-1.9127%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) :arrow_down:
parser ∅ <ø> (∅)
br 52.2504% <ø> (+4.2638%) :arrow_up:

codecov[bot] avatar Jun 28 '24 07:06 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [hawkingrei,zimulala]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 03 '24 16:07 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-07-03 03:09:27.579704407 +0000 UTC m=+1380294.065193241: :ballot_box_with_check: agreed by zimulala.
  • 2024-07-03 16:52:32.642615581 +0000 UTC m=+1429679.128104413: :ballot_box_with_check: agreed by hawkingrei.

ti-chi-bot[bot] avatar Jul 03 '24 16:07 ti-chi-bot[bot]

@HuSharp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 943236099f51743b31ca156732cc5aeb1415b31d link true /test fast_test_tiprow
tidb_parser_test 943236099f51743b31ca156732cc5aeb1415b31d link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tiprow[bot] avatar Jul 03 '24 16:07 tiprow[bot]