tidb icon indicating copy to clipboard operation
tidb copied to clipboard

handler: add `/schema?table_ids={...}`

Open lance6716 opened this issue 1 year ago • 3 comments

What problem does this PR solve?

Issue Number: close #54281

Problem Summary:

What changed and how does it work?

curl http://{TiDBIP}:10080/schema?table_ids={tableID,tableID,...}

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [x] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.
# curl http://127.0.0.1:10080/schema?table_ids=200104,200105,200106
{
 "200104": {
  "id": 200104,
  "name": {
   "O": "schema_migrations",
   "L": "schema_migrations"
  },
  "charset": "utf8mb4",
  "collate": "utf8mb4_general_ci",
  ...
 },
 "200105": {
  "id": 200105,
  "name": {
   "O": "ar_internal_metadata",
   "L": "ar_internal_metadata"
  },
  "charset": "utf8mb4",
  "collate": "utf8mb4_general_ci",
  ...
 },
 "200106": {
  "id": 200106,
  "name": {
   "O": "metered_rate_apipub_counts",
   "L": "metered_rate_apipub_counts"
  },
  "charset": "utf8mb4",
  "collate": "utf8mb4_general_ci",
  ...
 }
}

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

lance6716 avatar Jun 27 '24 08:06 lance6716

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 27 '24 08:06 tiprow[bot]

Codecov Report

Attention: Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 56.5699%. Comparing base (08147e7) to head (4df803e). Report is 25 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54280         +/-   ##
=================================================
- Coverage   72.8476%   56.5699%   -16.2778%     
=================================================
  Files          1542       1669        +127     
  Lines        436136     619352     +183216     
=================================================
+ Hits         317715     350367      +32652     
- Misses        98837     245475     +146638     
- Partials      19584      23510       +3926     
Flag Coverage Δ
integration 37.0984% <2.9411%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5347% <ø> (+6.6505%) :arrow_up:

codecov[bot] avatar Jun 27 '24 09:06 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 09 '24 06:07 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 06:35:09.086141354 +0000 UTC m=+339406.321375466: :ballot_box_with_check: agreed by D3Hunter.

ti-chi-bot[bot] avatar Jul 09 '24 06:07 ti-chi-bot[bot]

@lance6716: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 4df803e51277dc7f1d9c3b4528c90bd59ca0353f link true /test mysql-test
idc-jenkins-ci-tidb/unit-test 4df803e51277dc7f1d9c3b4528c90bd59ca0353f link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jul 10 '24 07:07 ti-chi-bot[bot]

If it's ready for review, you can remove the [WIP] label @lance6716

tiancaiamao avatar Jul 12 '24 08:07 tiancaiamao

Due to problems on keyvis side, I will open another PR to fix the issue. The API in this PR can't be used smoothly.

lance6716 avatar Jul 15 '24 02:07 lance6716

replaced by https://github.com/pingcap/tidb/pull/54608 (still WIP)

lance6716 avatar Jul 15 '24 03:07 lance6716