tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner, executor: fix index lookup join's inner index order should should be correctly mapped to join keys

Open AilinKid opened this issue 1 year ago • 4 comments

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/54064

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner, executor: fix index lookup join's inner index order should should be correctly mapped to join keys

AilinKid avatar Jun 26 '24 16:06 AilinKid

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from ailinkid, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 26 '24 16:06 ti-chi-bot[bot]

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 26 '24 16:06 tiprow[bot]

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.0804%. Comparing base (432bb79) to head (dec9200). Report is 129 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54249         +/-   ##
=================================================
- Coverage   72.9282%   56.0804%   -16.8478%     
=================================================
  Files          1523       1638        +115     
  Lines        435564     605535     +169971     
=================================================
+ Hits         317649     339587      +21938     
- Misses        98420     242564     +144144     
- Partials      19495      23384       +3889     
Flag Coverage Δ
integration 22.3308% <60.0000%> (?)
unit 71.8146% <96.6666%> (-0.1290%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6985% <ø> (+6.5299%) :arrow_up:

codecov[bot] avatar Jun 26 '24 16:06 codecov[bot]

@AilinKid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev dec92007db9b754cc26513c60726e0b9d3ced213 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 dec92007db9b754cc26513c60726e0b9d3ced213 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jun 27 '24 10:06 ti-chi-bot[bot]

after we discussion with the execution team, we are going to deprecate the index_merge_join hint.

AilinKid avatar Jul 17 '24 08:07 AilinKid