tidb
tidb copied to clipboard
planner: Optimized EXTRACT(<UNIT> FROM <partition_column>) for partition pruning.
What problem does this PR solve?
Issue Number: close #54210
Problem Summary:
What changed and how does it work?
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @mjonss. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
Attention: Patch coverage is 83.33333% with 10 lines in your changes missing coverage. Please review.
Project coverage is 75.4003%. Comparing base (
8b787f7) to head (78c2aac). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #54209 +/- ##
================================================
+ Coverage 72.8045% 75.4003% +2.5958%
================================================
Files 1568 1577 +9
Lines 439140 473670 +34530
================================================
+ Hits 319714 357149 +37435
+ Misses 99744 94858 -4886
- Partials 19682 21663 +1981
| Flag | Coverage Δ | |
|---|---|---|
| integration | 49.6167% <9.4339%> (?) |
|
| unit | 71.7725% <75.4717%> (-0.0266%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9567% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 57.2178% <ø> (+11.3378%) |
:arrow_up: |
/retest
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Defined2014, qw4990
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Defined2014,qw4990]
- ~~pkg/planner/OWNERS~~ [qw4990]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
2024-07-10 09:12:32.759017457 +0000 UTC m=+435249.994251570: :ballot_box_with_check: agreed by Defined2014.2024-08-02 09:37:43.041269436 +0000 UTC m=+82260.260031044: :ballot_box_with_check: agreed by qw4990.
@mjonss: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| tidb_parser_test | 3ab5cb1b335d857b5289826a86e8861bd993e3ed | link | true | /test tidb_parser_test |
| fast_test_tiprow | 3ab5cb1b335d857b5289826a86e8861bd993e3ed | link | true | /test fast_test_tiprow |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
In response to a cherrypick label: new pull request created to branch release-8.1: #55178.