tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: optimize the speed of full load

Open wjhuang2016 opened this issue 1 year ago • 6 comments

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

wjhuang2016 avatar Jun 24 '24 12:06 wjhuang2016

Codecov Report

Attention: Patch coverage is 75.82418% with 22 lines in your changes missing coverage. Please review.

Project coverage is 55.9648%. Comparing base (749d303) to head (e14753c). Report is 18 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54185         +/-   ##
=================================================
- Coverage   74.8731%   55.9648%   -18.9083%     
=================================================
  Files          1549       1666        +117     
  Lines        362122     607229     +245107     
=================================================
+ Hits         271132     339835      +68703     
- Misses        71455     244172     +172717     
- Partials      19535      23222       +3687     
Flag Coverage Δ
integration 35.7624% <73.2558%> (?)
unit 71.7231% <75.8241%> (-2.0782%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) :arrow_down:
parser ∅ <ø> (∅)
br 52.4726% <ø> (+4.7943%) :arrow_up:

codecov[bot] avatar Jun 25 '24 03:06 codecov[bot]

/retest

wjhuang2016 avatar Jun 25 '24 05:06 wjhuang2016

/retest

wjhuang2016 avatar Jun 28 '24 08:06 wjhuang2016

/retest

wjhuang2016 avatar Jul 01 '24 12:07 wjhuang2016

/retest

wjhuang2016 avatar Jul 02 '24 09:07 wjhuang2016

/retest

wjhuang2016 avatar Jul 02 '24 11:07 wjhuang2016

/retest

wjhuang2016 avatar Jul 04 '24 07:07 wjhuang2016

[LGTM Timeline notifier]

Timeline:

  • 2024-07-03 12:54:26.560072626 +0000 UTC m=+1415393.045561458: :ballot_box_with_check: agreed by tiancaiamao.
  • 2024-07-04 09:47:59.814663464 +0000 UTC m=+1490606.300152296: :ballot_box_with_check: agreed by lance6716.

ti-chi-bot[bot] avatar Jul 04 '24 09:07 ti-chi-bot[bot]

/approve

Benjamin2037 avatar Jul 11 '24 14:07 Benjamin2037

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, lance6716, tiancaiamao, windtalker, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 15 '24 02:07 ti-chi-bot[bot]

/retest

wjhuang2016 avatar Jul 15 '24 03:07 wjhuang2016