tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: fix br integration test

Open Leavrth opened this issue 1 year ago • 4 comments

What problem does this PR solve?

Issue Number: close #53835

Problem Summary:

What changed and how does it work?

  1. fix br integration test br_txn and br_full_ddl.
  2. add br integration test for corruption of snapshot/log backup file.

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [x] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Leavrth avatar Jun 05 '24 10:06 Leavrth

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 05 '24 10:06 tiprow[bot]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.8102%. Comparing base (b257e9b) to head (e6efeb8). Report is 163 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53836         +/-   ##
=================================================
- Coverage   73.0194%   60.8102%   -12.2093%     
=================================================
  Files          1577       1761        +184     
  Lines        440903     706248     +265345     
=================================================
+ Hits         321945     429471     +107526     
- Misses        99294     251577     +152283     
- Partials      19664      25200       +5536     
Flag Coverage Δ
integration 41.6739% <0.0000%> (?)
unit 75.2068% <0.0000%> (+3.1065%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.5253% <ø> (+1.5686%) :arrow_up:
parser ∅ <ø> (∅)
br 62.9557% <0.0000%> (+16.9964%) :arrow_up:

codecov[bot] avatar Jun 05 '24 10:06 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 10 '24 09:09 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-06-06 07:31:53.562696392 +0000 UTC m=+17867.616008315: :ballot_box_with_check: agreed by BornChanger.
  • 2024-09-10 09:07:45.345163579 +0000 UTC m=+347335.085587517: :ballot_box_with_check: agreed by 3pointer.

ti-chi-bot[bot] avatar Sep 10 '24 09:09 ti-chi-bot[bot]

@Leavrth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow e6efeb88676eb70cbb3a31b2ad9bd9c1fbb05aa9 link true /test fast_test_tiprow
tidb_parser_test e6efeb88676eb70cbb3a31b2ad9bd9c1fbb05aa9 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tiprow[bot] avatar Sep 10 '24 09:09 tiprow[bot]

/retest

Leavrth avatar Sep 10 '24 10:09 Leavrth

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 10 '24 10:09 tiprow[bot]

/retest

BornChanger avatar Sep 13 '24 21:09 BornChanger

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 13 '24 21:09 tiprow[bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #56078.

ti-chi-bot avatar Sep 13 '24 22:09 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.5: #56079.

ti-chi-bot avatar Sep 13 '24 22:09 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.1: #56080.

ti-chi-bot avatar Sep 13 '24 22:09 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-6.5: #56081.

ti-chi-bot avatar Sep 13 '24 22:09 ti-chi-bot