br: ks3 domain mode
What problem does this PR solve?
Issue Number: close #53775
Problem Summary: introduce domain mode for ks3 sdk
What changed and how does it work?
for ks3 server,
-
path//fileandpath/fileare different places. - return http status code 404 if file does not exist.
- use ks3 sdk in default if the endpoint contains
ksyuncs.com.
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @Leavrth. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
:x: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 74.4216%. Comparing base (5ed9e63) to head (07a5752).
:warning: Report is 1435 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #53790 +/- ##
================================================
+ Coverage 73.0400% 74.4216% +1.3816%
================================================
Files 1684 1730 +46
Lines 465705 473818 +8113
================================================
+ Hits 340151 352623 +12472
+ Misses 104635 98795 -5840
- Partials 20919 22400 +1481
| Flag | Coverage Δ | |
|---|---|---|
| integration | 44.8807% <0.0000%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | ∅ <ø> (∅) |
|
| parser | ∅ <ø> (∅) |
|
| br | 60.7011% <0.0000%> (+14.7327%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
/lgtm
[LGTM Timeline notifier]
Timeline:
-
2024-06-04 10:06:49.5910604 +0000 UTC m=+3375763.348195968: :ballot_box_with_check: agreed by lance6716.
@lance6716: Your lgtm message is repeated, so it is ignored.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lance6716
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~br/pkg/storage/OWNERS~~ [lance6716]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Leavrth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| idc-jenkins-ci-tidb/unit-test | 07a5752771ab927d69b363dd772aac2f6da70e65 | link | true | /test unit-test |
| idc-jenkins-ci-tidb/check_dev_2 | 07a5752771ab927d69b363dd772aac2f6da70e65 | link | true | /test check-dev2 |
| pull-integration-realcluster-test-next-gen | 07a5752771ab927d69b363dd772aac2f6da70e65 | link | true | /test pull-integration-realcluster-test-next-gen |
| pull-unit-test-next-gen | 07a5752771ab927d69b363dd772aac2f6da70e65 | link | true | /test pull-unit-test-next-gen |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.